all repos — openbox @ 8772b46b56172e35506f21d626aa89bd649615c6

openbox fork - make it a bit more like ryudo

allow focus to fallback to omnipresent windows, except during desktop switching which is when they are vile
Dana Jansens danakj@orodu.net
commit

8772b46b56172e35506f21d626aa89bd649615c6

parent

9a7c4de2eb73826da9b4415541735f8d7c161c23

5 files changed, 16 insertions(+), 11 deletions(-)

jump to
M openbox/action.copenbox/action.c

@@ -1314,7 +1314,7 @@

void action_unfocus (union ActionData *data) { if (data->client.any.c == focus_client) - focus_fallback(FALSE, FALSE); + focus_fallback(FALSE, FALSE, TRUE); } void action_iconify(union ActionData *data)
M openbox/event.copenbox/event.c

@@ -499,7 +499,7 @@ "Focus went to the frame window");

focus_left_screen = FALSE; - focus_fallback(FALSE, FALSE); + focus_fallback(FALSE, FALSE, TRUE); /* We don't get a FocusOut for this case, because it's just moving from our Inferior up to us. This happens when iconifying a

@@ -551,7 +551,7 @@ worry about focusing an invalid window

*/ if (!focus_left_screen) - focus_fallback(FALSE, FALSE); + focus_fallback(FALSE, FALSE, TRUE); } } else if (!client)

@@ -607,7 +607,7 @@ that isn't a client. */

ob_debug_type(OB_DEBUG_FOCUS, "Focus went to an unmanaged window 0x%x !\n", ce.xfocus.window); - focus_fallback(TRUE, FALSE); + focus_fallback(TRUE, FALSE, TRUE); } }
M openbox/focus.copenbox/focus.c

@@ -97,6 +97,7 @@ }

static ObClient* focus_fallback_target(gboolean allow_refocus, gboolean allow_pointer, + gboolean allow_omnipresent, ObClient *old) { GList *it;

@@ -118,12 +119,13 @@ for (it = focus_order; it; it = g_list_next(it)) {

c = it->data; /* fallback focus to a window if: 1. it is on the current desktop. this ignores omnipresent - windows, which are problematic in their own rite. + windows, which are problematic in their own rite, unless they are + specifically allowed 2. it is a normal type window, don't fall back onto a dock or a splashscreen or a desktop window (save the desktop as a backup fallback though) */ - if (c->desktop == screen_desktop && + if ((allow_omnipresent || c->desktop == screen_desktop) && client_normal(c) && (allow_refocus || client_focus_target(c) != old) && client_focus(c))

@@ -155,7 +157,8 @@

return NULL; } -ObClient* focus_fallback(gboolean allow_refocus, gboolean allow_pointer) +ObClient* focus_fallback(gboolean allow_refocus, gboolean allow_pointer, + gboolean allow_omnipresent) { ObClient *new; ObClient *old = focus_client;

@@ -165,7 +168,8 @@ and such, and then when we try focus them, we won't get a FocusIn

event at all for them. */ focus_nothing(); - new = focus_fallback_target(allow_refocus, allow_pointer, old); + new = focus_fallback_target(allow_refocus, allow_pointer, + allow_omnipresent, old); /* get what was really focused */ if (new) new = client_focus_target(new);
M openbox/focus.hopenbox/focus.h

@@ -45,7 +45,8 @@ void focus_nothing();

/*! Call this when you need to focus something! */ struct _ObClient* focus_fallback(gboolean allow_refocus, - gboolean allow_pointer); + gboolean allow_pointer, + gboolean allow_omnipresent); /*! Add a new client into the focus order */ void focus_order_add_new(struct _ObClient *c);
M openbox/screen.copenbox/screen.c

@@ -587,7 +587,7 @@

do this before hiding the windows so if helper windows are coming with us, they don't get hidden */ - if (dofocus && (c = focus_fallback(TRUE, !config_focus_last))) + if (dofocus && (c = focus_fallback(TRUE, !config_focus_last, FALSE))) { /* only do the flicker reducing stuff ahead of time if we are going to call xsetinputfocus on the window ourselves. otherwise there is

@@ -1050,7 +1050,7 @@ }

else if (!show_only) { ObClient *c; - if ((c = focus_fallback(TRUE, FALSE))) { + if ((c = focus_fallback(TRUE, FALSE, TRUE))) { /* only do the flicker reducing stuff ahead of time if we are going to call xsetinputfocus on the window ourselves. otherwise there is no guarantee the window will actually take focus.. */