all repos — openbox @ a9a5f0d7510be5dbf8ae1db99e6c1c01035503d9

openbox fork - make it a bit more like ryudo

put event bindings in OBBindings too
Dana Jansens danakj@orodu.net
commit

a9a5f0d7510be5dbf8ae1db99e6c1c01035503d9

parent

a0350e27b311db5cab49035752d3852ee68bf8a2

5 files changed, 71 insertions(+), 70 deletions(-)

jump to
M src/actions.ccsrc/actions.cc

@@ -23,9 +23,6 @@ : _button(0)

{ for (int i=0; i<BUTTONS; ++i) _posqueue[i] = new ButtonPressAction(); - - for (int i = 0; i < NUM_EVENTS; ++i) - _callback[i] = 0; }

@@ -150,11 +147,9 @@ {

OtkEventHandler::enterHandler(e); // run the ENTER python hook - if (_callback[EventEnterWindow]) { - EventData *data = new_event_data(e.window, EventEnterWindow, e.state); - python_callback(_callback[EventEnterWindow], (PyObject*)data); - Py_DECREF((PyObject*)data); - } + EventData *data = new_event_data(e.window, EventEnterWindow, e.state); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); }

@@ -163,11 +158,9 @@ {

OtkEventHandler::leaveHandler(e); // run the LEAVE python hook - if (_callback[EventLeaveWindow]) { - EventData *data = new_event_data(e.window, EventLeaveWindow, e.state); - python_callback(_callback[EventLeaveWindow], (PyObject*)data); - Py_DECREF((PyObject*)data); - } + EventData *data = new_event_data(e.window, EventLeaveWindow, e.state); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); }

@@ -221,64 +214,27 @@ void OBActions::mapRequestHandler(const XMapRequestEvent &e)

{ OtkEventHandler::mapRequestHandler(e); - if (_callback[EventNewWindow]) { - EventData *data = new_event_data(e.window, EventNewWindow, 0); - python_callback(_callback[EventNewWindow], (PyObject*)data); - Py_DECREF((PyObject*)data); - } + EventData *data = new_event_data(e.window, EventNewWindow, 0); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } void OBActions::unmapHandler(const XUnmapEvent &e) { OtkEventHandler::unmapHandler(e); - if (_callback[EventCloseWindow]) { - EventData *data = new_event_data(e.window, EventCloseWindow, 0); - python_callback(_callback[EventCloseWindow], (PyObject*)data); - Py_DECREF((PyObject*)data); - } + EventData *data = new_event_data(e.window, EventCloseWindow, 0); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } void OBActions::destroyHandler(const XDestroyWindowEvent &e) { OtkEventHandler::destroyHandler(e); - if (_callback[EventCloseWindow]) { - EventData *data = new_event_data(e.window, EventCloseWindow, 0); - python_callback(_callback[EventCloseWindow], (PyObject*)data); - Py_DECREF((PyObject*)data); - } -} - -bool OBActions::bind(EventAction action, PyObject *func) -{ - if (action < 0 || action >= NUM_EVENTS) { - return false; - } - - Py_XDECREF(_callback[action]); - _callback[action] = func; - Py_INCREF(func); - return true; -} - -bool OBActions::unbind(EventAction action) -{ - if (action < 0 || action >= NUM_EVENTS) { - return false; - } - - Py_XDECREF(_callback[action]); - _callback[action] = 0; - return true; -} - -void OBActions::unbindAll() -{ - for (int i = 0; i < NUM_EVENTS; ++i) { - Py_XDECREF(_callback[i]); - _callback[i] = 0; - } + EventData *data = new_event_data(e.window, EventCloseWindow, 0); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } }
M src/actions.hhsrc/actions.hh

@@ -60,8 +60,6 @@

void insertPress(const XButtonEvent &e); void removePress(const XButtonEvent &e); - PyObject *_callback[NUM_EVENTS]; - public: //! Constructs an OBActions object OBActions();

@@ -82,14 +80,6 @@ virtual void mapRequestHandler(const XMapRequestEvent &e);

virtual void unmapHandler(const XUnmapEvent &e); virtual void destroyHandler(const XDestroyWindowEvent &e); - //! Bind a callback for an action - bool bind(EventAction action, PyObject *func); - - //! Unbind the callback function from an action - bool unbind(EventAction action); - - //! Remove all callback functions - void unbindAll(); }; }
M src/bindings.ccsrc/bindings.cc

@@ -147,6 +147,9 @@ {

_timer.setTimeout(5000); // chains reset after 5 seconds setResetKey("C-g"); // set the default reset key + + for (int i = 0; i < NUM_EVENTS; ++i) + _events[i] = 0; }

@@ -155,6 +158,7 @@ {

grabKeys(false); removeAllKeys(); removeAllButtons(); + removeAllEvents(); }

@@ -491,6 +495,44 @@ (*it)->binding.modifiers == data->state) {

if ((*it)->callback[data->action]) python_callback((*it)->callback[data->action], (PyObject*)data); } +} + + +bool OBBindings::addEvent(EventAction action, PyObject *callback) +{ + if (action < 0 || action >= NUM_EVENTS) { + return false; + } + + Py_XDECREF(_events[action]); + _events[action] = callback; + Py_INCREF(callback); + return true; +} + +bool OBBindings::removeEvent(EventAction action) +{ + if (action < 0 || action >= NUM_EVENTS) { + return false; + } + + Py_XDECREF(_events[action]); + _events[action] = 0; + return true; +} + +void OBBindings::removeAllEvents() +{ + for (int i = 0; i < NUM_EVENTS; ++i) { + Py_XDECREF(_events[i]); + _events[i] = 0; + } +} + +void OBBindings::fireEvent(EventData *data) +{ + if (_events[data->action]) + python_callback(_events[data->action], (PyObject*)data); } }
M src/bindings.hhsrc/bindings.hh

@@ -84,6 +84,8 @@ ButtonBindingList _buttons[NUM_MOUSE_CONTEXT];

void grabButton(bool grab, const Binding &b, MouseContext context, OBClient *client); + + PyObject *_events[NUM_EVENTS]; public: //! Initializes an OBBindings object

@@ -127,6 +129,17 @@ //! Removes all button bindings

void removeAllButtons(); void fireButton(ButtonData *data); + + //! Bind a callback for an event + bool addEvent(EventAction action, PyObject *callback); + + //! Unbind the callback function from an event + bool removeEvent(EventAction action); + + //! Remove all callback functions + void removeAllEvents(); + + void fireEvent(EventData *data); }; }
M src/python.ccsrc/python.cc

@@ -455,7 +455,7 @@ PyErr_SetString(PyExc_TypeError, "Invalid callback function.");

return NULL; } - if (!ob::Openbox::instance->actions()->bind(action, func)) { + if (!ob::Openbox::instance->bindings()->addEvent(action, func)) { PyErr_SetString(PyExc_RuntimeError,"Unable to add binding."); return NULL; }