all repos — openbox @ b8653c3ab8ee785fc0605a960ac83afb97ac7edf

openbox fork - make it a bit more like ryudo

better comments for the frame and its widgets' adjust() method
Dana Jansens danakj@orodu.net
commit

b8653c3ab8ee785fc0605a960ac83afb97ac7edf

parent

1e7c9071de6f617f06008a5bb5572af40289a218

5 files changed, 14 insertions(+), 15 deletions(-)

jump to
M src/backgroundwidget.ccsrc/backgroundwidget.cc

@@ -81,7 +81,7 @@

void OBBackgroundWidget::adjust() { - // XXX: adjust shit + // nothing to adjust here. its done in OBFrame::adjustSize } }
M src/buttonwidget.ccsrc/buttonwidget.cc

@@ -132,7 +132,7 @@

void OBButtonWidget::adjust() { - // XXX: adjust shit + // nothing to adjust. no children. }
M src/frame.ccsrc/frame.cc

@@ -116,6 +116,7 @@

void OBFrame::adjust() { + // the party all happens in adjustSize }

@@ -128,6 +129,7 @@

int width; // the width of the client and its border int bwidth; // width to make borders int cbwidth; // width of the inner client border + const int bevel = _style->getBevelWidth(); if (_decorations & OBClient::Decor_Border) { bwidth = _style->getBorderWidth();

@@ -151,33 +153,31 @@ // set the titlebar size

_titlebar.setGeometry(-bwidth, -bwidth, width, - (_style->getFont()->height() + - _style->getBevelWidth() * 2)); + _style->getFont()->height() + bevel * 2); _innersize.top += _titlebar.height() + bwidth; // set the label size - _label.setGeometry(0, _style->getBevelWidth(), - width, _style->getFont()->height()); + _label.setGeometry(0, bevel, width, _style->getFont()->height()); // set the buttons sizes if (_decorations & OBClient::Decor_Iconify) - _button_iconify.setGeometry(0, _style->getBevelWidth() + 1, + _button_iconify.setGeometry(0, bevel + 1, _label.height() - 2, _label.height() - 2); if (_decorations & OBClient::Decor_Maximize) - _button_max.setGeometry(0, _style->getBevelWidth() + 1, + _button_max.setGeometry(0, bevel + 1, _label.height() - 2, _label.height() - 2); if (_decorations & OBClient::Decor_Sticky) - _button_stick.setGeometry(0, _style->getBevelWidth() + 1, + _button_stick.setGeometry(0, bevel + 1, _label.height() - 2, _label.height() - 2); if (_decorations & OBClient::Decor_Close) - _button_close.setGeometry(0, _style->getBevelWidth() + 1, + _button_close.setGeometry(0, bevel + 1, _label.height() - 2, _label.height() - 2); // separation between titlebar elements - const int sep = _style->getBevelWidth() + 1; + const int sep = bevel + 1; std::string layout = "SLIMC"; // XXX: get this from somewhere // XXX: it is REQUIRED that by this point, the string only has one of each

@@ -284,8 +284,6 @@ _handle.show(true);

else _handle.hide(true); - // XXX: more is gunna have to happen here - _size.left = _innersize.left + bwidth; _size.right = _innersize.right + bwidth; _size.top = _innersize.top + bwidth;
M src/frame.hhsrc/frame.hh

@@ -93,8 +93,9 @@

//! Set the style to decorate the frame with virtual void setStyle(otk::Style *style); - //! Realign children + //! Empty overridden method to prevent automatic alignment of children virtual void adjust(); + //! Displays focused decorations virtual void focus(); //! Displays unfocused decorations
M src/labelwidget.ccsrc/labelwidget.cc

@@ -113,7 +113,7 @@

void OBLabelWidget::adjust() { - // XXX: adjust shit + // nothing to adjust. no children. } }