all repos — openbox @ bddbe9432837edccc67b76f2d29d4dbc9b02203f

openbox fork - make it a bit more like ryudo

make ob_state a function so it cant be changed outside of openbox.c
Dana Jansens danakj@orodu.net
commit

bddbe9432837edccc67b76f2d29d4dbc9b02203f

parent

35418ca0fcd3fd28ef579f4435b8bad3b7c87f04

M openbox/client.copenbox/client.c

@@ -256,7 +256,7 @@ /* update the focus lists */

focus_order_add_new(self); /* focus the new window? */ - if (ob_state != OB_STATE_STARTING && config_focus_new && + if (ob_state() != OB_STATE_STARTING && config_focus_new && (self->type == OB_CLIENT_TYPE_NORMAL || self->type == OB_CLIENT_TYPE_DIALOG)) { gboolean group_foc = FALSE;

@@ -405,7 +405,7 @@ /* reparent the window out of the frame, and free the frame */

frame_release_client(self->frame, self); self->frame = NULL; - if (ob_state != OB_STATE_EXITING) { + if (ob_state() != OB_STATE_EXITING) { /* these values should not be persisted across a window unmapping/mapping */ prop_erase(self->window, prop_atoms.net_wm_desktop);

@@ -1125,7 +1125,7 @@ self->can_focus = hints->input;

/* only do this when first managing the window *AND* when we aren't starting up! */ - if (ob_state != OB_STATE_STARTING && self->frame == NULL) + if (ob_state() != OB_STATE_STARTING && self->frame == NULL) if (hints->flags & StateHint) self->iconic = hints->initial_state == IconicState;
M openbox/dock.copenbox/dock.c

@@ -93,7 +93,7 @@ it. There are 2 unmap events generated that we see, one with the 'event'

member set the root window, and one set to the client, but both get handled and need to be ignored. */ - if (ob_state == OB_STATE_STARTING) + if (ob_state() == OB_STATE_STARTING) app->ignore_unmaps += 2; if (app->win != app->icon_win) {
M openbox/event.copenbox/event.c

@@ -650,7 +650,7 @@ frame_adjust_focus(client->frame, FALSE);

break; case EnterNotify: if (client_normal(client)) { - if (ob_state == OB_STATE_STARTING) { + if (ob_state() == OB_STATE_STARTING) { /* move it to the top of the focus order */ guint desktop = client->desktop; if (desktop == DESKTOP_ALL) desktop = screen_desktop;
M openbox/focus.copenbox/focus.c

@@ -94,7 +94,7 @@ if (client != NULL)

push_to_top(client); /* set the NET_ACTIVE_WINDOW hint, but preserve it on shutdown */ - if (ob_state != OB_STATE_EXITING) { + if (ob_state() != OB_STATE_EXITING) { active = client ? client->window : None; PROP_SET32(RootWindow(ob_display, ob_screen), net_active_window, window, active);
M openbox/frame.copenbox/frame.c

@@ -349,7 +349,7 @@ it. There are 2 unmap events generated that we see, one with the 'event'

member set the root window, and one set to the client, but both get handled and need to be ignored. */ - if (ob_state == OB_STATE_STARTING) + if (ob_state() == OB_STATE_STARTING) client->ignore_unmaps += 2; /* select the event mask on the client's parent (to receive config/map
M openbox/openbox.copenbox/openbox.c

@@ -59,10 +59,10 @@ RrInstance *ob_rr_inst;

RrTheme *ob_rr_theme; Display *ob_display; gint ob_screen; -ObState ob_state; Cursor ob_cursors[OB_NUM_CURSORS]; KeyCode ob_keys[OB_NUM_KEYS]; +static ObState state; static gboolean sync; static gboolean shutdown; static gboolean restart;

@@ -91,7 +91,7 @@ char *path;

xmlDocPtr doc; xmlNodePtr node; - ob_state = OB_STATE_STARTING; + state = OB_STATE_STARTING; /* initialize the locale */ if (!setlocale(LC_ALL, ""))

@@ -256,10 +256,10 @@

/* get all the existing windows */ client_manage_all(); - ob_state = OB_STATE_RUNNING; + state = OB_STATE_RUNNING; while (!shutdown) event_loop(); - ob_state = OB_STATE_EXITING; + state = OB_STATE_EXITING; dock_remove_all(); client_unmanage_all();

@@ -612,3 +612,8 @@ {

g_assert(key < OB_NUM_KEYS); return ob_keys[key]; } + +ObState ob_state() +{ + return state; +}
M openbox/openbox.hopenbox/openbox.h

@@ -28,7 +28,7 @@ /*! The number of the screen on which we're running */

extern gint ob_screen; /* The state of execution of the window manager */ -extern ObState ob_state; +ObState ob_state(); void ob_restart_other(const gchar *path); void ob_restart();
M openbox/screen.copenbox/screen.c

@@ -257,7 +257,7 @@ screen_physical_size.height = geometry[1] = h;

PROP_SETA32(RootWindow(ob_display, ob_screen), net_desktop_geometry, cardinal, geometry, 2); - if (ob_state == OB_STATE_STARTING) + if (ob_state() == OB_STATE_STARTING) return; dock_configure();
M openbox/stacking.copenbox/stacking.c

@@ -18,7 +18,7 @@

/* on shutdown, don't update the properties, so that we can read it back in on startup and re-stack the windows as they were before we shut down */ - if (ob_state == OB_STATE_EXITING) return; + if (ob_state() == OB_STATE_EXITING) return; /* create an array of the window ids (from bottom to top, reverse order!) */
M plugins/placement/history.cplugins/placement/history.c

@@ -58,7 +58,7 @@ hi = history_find(c->name, c->class, c->role);

if (hi && !(hi->flags & PLACED)) { hi->flags |= PLACED; - if (ob_state != OB_STATE_STARTING) { + if (ob_state() != OB_STATE_STARTING) { if (hi->flags & HAVE_POSITION || hi->flags & HAVE_SIZE) { if (hi->flags & HAVE_POSITION) {
M plugins/placement/placement.cplugins/placement/placement.c

@@ -30,7 +30,7 @@ int l, r, t, b;

int x, y; Rect *area; - if (ob_state == OB_STATE_STARTING) return; + if (ob_state() == OB_STATE_STARTING) return; area = screen_area_monitor(c->desktop, g_random_int_range(0, screen_num_monitors));