all repos — openbox @ d8c518978b3fee96eb446fc01884d8f3b2a45a7c

openbox fork - make it a bit more like ryudo

placement improvements?

when placing transients don't place them relative to iconified parents.
try place avoiding max/fullscreen windows first, then ignore them entirely if that fails.
Dana Jansens danakj@orodu.net
commit

d8c518978b3fee96eb446fc01884d8f3b2a45a7c

parent

f869ec5121afaf74ff3a7a420923878c093f9c08

1 files changed, 14 insertions(+), 8 deletions(-)

jump to
M openbox/place.copenbox/place.c

@@ -274,7 +274,7 @@ c->desktop != (placer->desktop == DESKTOP_ALL ? \

screen_desktop : placer->desktop))) static gboolean place_smart(ObClient *client, gint *x, gint *y, - ObSmartType type) + ObSmartType type, gboolean ignore_max) { gboolean ret = FALSE; GSList *spaces = NULL, *sit;

@@ -299,7 +299,8 @@ ObClient *c;

if (WINDOW_IS_CLIENT(it->data)) { c = it->data; - if (c->fullscreen || (c->max_vert && c->max_horz)) + if (ignore_max && + (c->fullscreen || (c->max_vert && c->max_horz))) continue; } else continue;

@@ -323,7 +324,8 @@ ObClient *c;

if (WINDOW_IS_CLIENT(it->data)) { c = it->data; - if (c->fullscreen || (c->max_vert && c->max_horz)) + if (ignore_max && + (c->fullscreen || (c->max_vert && c->max_horz))) continue; } else continue;

@@ -440,7 +442,7 @@

static gboolean place_transient_splash(ObClient *client, gint *x, gint *y) { if (client->transient_for && client->type == OB_CLIENT_TYPE_DIALOG) { - if (client->transient_for != OB_TRAN_GROUP) { + if (client->transient_for != OB_TRAN_GROUP && !client->iconic) { ObClient *c = client; ObClient *p = client->transient_for;

@@ -457,7 +459,9 @@ gboolean first = TRUE;

gint l, r, t, b; for (it = client->group->members; it; it = g_slist_next(it)) { ObClient *m = it->data; - if (!(m == client || m->transient_for) && client_normal(m)) { + if (!(m == client || m->transient_for) && client_normal(m) && + !m->iconic) + { if (first) { l = RECT_LEFT(m->frame->area); t = RECT_TOP(m->frame->area);

@@ -510,9 +514,11 @@ else if (!(

place_per_app_setting(client, x, y, settings) || ((config_place_policy == OB_PLACE_POLICY_MOUSE) ? place_under_mouse(client, x, y) : - place_smart(client, x, y, SMART_FULL) || - place_smart(client, x, y, SMART_GROUP) || - place_smart(client, x, y, SMART_FOCUSED) || + place_smart(client, x, y, SMART_FULL, FALSE) || + place_smart(client, x, y, SMART_FULL, TRUE) || + place_smart(client, x, y, SMART_GROUP, FALSE) || + place_smart(client, x, y, SMART_GROUP, TRUE) || + place_smart(client, x, y, SMART_FOCUSED, TRUE) || place_random(client, x, y)))) g_assert_not_reached(); /* the last one better succeed */ /* get where the client should be */