all repos — tint2 @ 27a8ea013e05c37b3a226c2bb7749bb54e0d6a61

fork of the tint2 desktop panel for my custom setup - only minimized windows across all desktops for the taskbar 

Fix crashing when a window icon is large

If an icon of a window is large tint2 crashes with segmentation fault, I guess because of stack overflow. This changes the allocation of icon_data from stack to heap.
santouits santouits@users.noreply.github.com
commit

27a8ea013e05c37b3a226c2bb7749bb54e0d6a61

parent

78313502d3b26c217f5583a23ef571bc9e0edc45

1 files changed, 10 insertions(+), 4 deletions(-)

jump to
M src/taskbar/task.c → src/taskbar/task.c 
@@ -312,10 +312,16 @@ // get ARGB icon
                 int w, h;
                 gulong *tmp_data = get_best_icon(data, get_icon_count(data, len), len, &w, &h, icon_size);
                 if (tmp_data) {
-                    DATA32 icon_data[w * h];
-                    for (int j = 0; j < w * h; ++j)
-                        icon_data[j] = tmp_data[j];
-                    img = imlib_create_image_using_copied_data(w, h, icon_data);
+                    int array_size = w * h;
+                    // imlib needs the array in DATA32 type
+                    // using malloc for the array to protect from stack overflow
+                    DATA32 *icon_data = (DATA32*) g_try_malloc(sizeof(*icon_data) * array_size);
+                    if (icon_data) {
+                        for (int j = 0; j < array_size; ++j)
+                            icon_data[j] = tmp_data[j];
+                        img = imlib_create_image_using_copied_data(w, h, icon_data);
+                        g_free(icon_data);
+                    }
                 }
             }
             XFree(data);