all repos — tint2 @ 2c9cfb229d002da6b7bbdd0f383ad366d54c0237

fork of the tint2 desktop panel for my custom setup - only minimized windows across all desktops for the taskbar

*fix* hopefully fixed issue 212 (thx to l_man for testing)


git-svn-id: http://tint2.googlecode.com/svn/trunk@388 121b4492-b84c-0410-8b4c-0d4edfb3f3cc
Andreas.Fink85 Andreas.Fink85@121b4492-b84c-0410-8b4c-0d4edfb3f3cc
commit

2c9cfb229d002da6b7bbdd0f383ad366d54c0237

parent

527d603e98773c6a41a6fbea37e1da1c93549b3b

1 files changed, 22 insertions(+), 2 deletions(-)

jump to
M src/systray/systraybar.csrc/systray/systraybar.c

@@ -27,6 +27,8 @@ #include <glib.h>

#include <Imlib2.h> #include <X11/extensions/Xdamage.h> #include <X11/extensions/Xcomposite.h> +#include <X11/extensions/Xrender.h> + #include "systraybar.h" #include "server.h"

@@ -513,8 +515,25 @@ // good systray icons support 32 bit depth, but some icons are still 24 bit.

// We create a heuristic mask for these icons, i.e. we get the rgb value in the top left corner, and // mask out all pixel with the same rgb value Panel* panel = systray.area.panel; - imlib_context_set_drawable(traywin->id); - Imlib_Image image = imlib_create_image_from_drawable(0, 0, 0, traywin->width, traywin->height, 0); + + // Very ugly hack, but somehow imlib2 is not able to get the image from the traywindow itself, + // so we first render the tray window onto a pixmap, and then we tell imlib2 to use this pixmap as + // drawable. If someone knows why it does not work with the traywindow itself, please tell me ;) + Pixmap tmp_pmap = XCreatePixmap(server.dsp, server.root_win, traywin->width, traywin->height, server.depth); + XRenderPictFormat* f; + if (traywin->depth == 24) + f = XRenderFindVisualFormat(server.dsp, DefaultVisual(server.dsp, 0)); + else + f = XRenderFindVisualFormat(server.dsp, server.visual); + Picture pict_image = XRenderCreatePicture(server.dsp, traywin->tray_id, f, 0, 0); + Picture pict_drawable = XRenderCreatePicture(server.dsp, tmp_pmap, XRenderFindVisualFormat(server.dsp, server.visual), 0, 0); + XRenderComposite(server.dsp, PictOpSrc, pict_image, None, pict_drawable, 0, 0, 0, 0, 0, 0, traywin->width, traywin->height); + XRenderFreePicture(server.dsp, pict_image); + XRenderFreePicture(server.dsp, pict_drawable); + // end of the ugly hack and we can continue as before + + imlib_context_set_drawable(tmp_pmap); + Imlib_Image image = imlib_create_image_from_drawable(0, 0, 0, traywin->width, traywin->height, 1); if (image == 0) return;

@@ -537,6 +556,7 @@ render_image(systray.area.pix, traywin->x-systray.area.posx, traywin->y-systray.area.posy, traywin->width, traywin->height);

} XCopyArea(server.dsp, systray.area.pix, panel->main_win, server.gc, traywin->x-systray.area.posx, traywin->y-systray.area.posy, traywin->width, traywin->height, traywin->x, traywin->y); imlib_free_image_and_decache(); + XFreePixmap(server.dsp, tmp_pmap); if (traywin->damage) XDamageSubtract(server.dsp, traywin->damage, None, None);