all repos — tint2 @ 8917a4d15b15a06915bf6a4a52d90271675568a9

fork of the tint2 desktop panel for my custom setup - only minimized windows across all desktops for the taskbar 

Remove _NET_WM_ICON_GEOMETRY for hidden task buttons (issue #634)
o9000 mrovi9000@gmail.com
commit

8917a4d15b15a06915bf6a4a52d90271675568a9

parent

87ca2071073219c04f573f8ee76165721b3323c9

1 files changed, 45 insertions(+), 26 deletions(-)

jump to
M src/taskbar/task.c → src/taskbar/task.c 
@@ -289,7 +289,12 @@ for (int j = 0; j < w * h; ++j)
 				icon_data[j] = tmp_data[j];
 			img = imlib_create_image_using_copied_data(w, h, icon_data);
 			if (img)
-				fprintf(stderr, "%s: Got %dx%d icon via _NET_WM_ICON for %s\n", __FUNCTION__, w, h, task->title ? task->title : "task");
+				fprintf(stderr,
+				        "%s: Got %dx%d icon via _NET_WM_ICON for %s\n",
+				        __FUNCTION__,
+				        w,
+				        h,
+				        task->title ? task->title : "task");
 			XFree(data);
 		}
 	}

@@ -308,7 +313,12 @@ XGetGeometry(server.display, hints->icon_pixmap, &root, &icon_x, &icon_y, &w, &h, &border_width, &bpp);
 				imlib_context_set_drawable(hints->icon_pixmap);
 				img = imlib_create_image_from_drawable(hints->icon_mask, 0, 0, w, h, 0);
 				if (img)
-					fprintf(stderr, "%s: Got %dx%d pixmap icon via WM_HINTS for %s\n", __FUNCTION__, w, h, task->title ? task->title : "task");
+					fprintf(stderr,
+					        "%s: Got %dx%d pixmap icon via WM_HINTS for %s\n",
+					        __FUNCTION__,
+					        w,
+					        h,
+					        task->title ? task->title : "task");
 			}
 			XFree(hints);
 		}

@@ -454,22 +464,22 @@ Task *task = (Task *)obj;
 	Panel *panel = (Panel *)task->area.panel;
 
 	fprintf(stderr,
-			"%*sText: x = %d, y = %d, w = %d, h = %d, align = %s, text = %s\n",
-			indent,
-			"",
-			(int)panel->g_task.text_posx,
-			(int)task->_text_posy,
-			task->_text_width,
-			task->_text_height,
-			panel->g_task.centered ? "center" : "left",
-			task->title);
+	        "%*sText: x = %d, y = %d, w = %d, h = %d, align = %s, text = %s\n",
+	        indent,
+	        "",
+	        (int)panel->g_task.text_posx,
+	        (int)task->_text_posy,
+	        task->_text_width,
+	        task->_text_height,
+	        panel->g_task.centered ? "center" : "left",
+	        task->title);
 	fprintf(stderr,
-			"%*sIcon: x = %d, y = %d, w = h = %d\n",
-			indent,
-			"",
-			task->_icon_x,
-			task->_icon_y,
-			panel->g_task.icon_size1);
+	        "%*sIcon: x = %d, y = %d, w = h = %d\n",
+	        indent,
+	        "",
+	        task->_icon_x,
+	        task->_icon_y,
+	        panel->g_task.icon_size1);
 }
 
 int task_compute_desired_size(void *obj)

@@ -485,15 +495,24 @@ {
 	Task *task = (Task *)obj;
 	Panel *panel = (Panel *)task->area.panel;
 
-	long value[] = {panel->posx + task->area.posx, panel->posy + task->area.posy, task->area.width, task->area.height};
-	XChangeProperty(server.display,
-	                task->win,
-	                server.atom._NET_WM_ICON_GEOMETRY,
-	                XA_CARDINAL,
-	                32,
-	                PropModeReplace,
-	                (unsigned char *)value,
-	                4);
+	if (task->area.on_screen) {
+		long value[] = {panel->posx + task->area.posx,
+						panel->posy + task->area.posy,
+						task->area.width,
+						task->area.height};
+		XChangeProperty(server.display,
+						task->win,
+						server.atom._NET_WM_ICON_GEOMETRY,
+						XA_CARDINAL,
+						32,
+						PropModeReplace,
+						(unsigned char *)value,
+						4);
+	} else {
+		XDeleteProperty(server.display,
+						task->win,
+						server.atom._NET_WM_ICON_GEOMETRY);
+	}
 }
 
 Task *find_active_task(Task *current_task)