all repos — tint2 @ cb17e5a662e7c0c40db9b089134c8e925731d3d6

fork of the tint2 desktop panel for my custom setup - only minimized windows across all desktops for the taskbar

systray: Sort icons in the correct order when an icon is empty and order is right2left
o9000 o9000
commit

cb17e5a662e7c0c40db9b089134c8e925731d3d6

parent

ea67f2405115f3bf53d2eec4e8c9e6f60f81999f

4 files changed, 22 insertions(+), 10 deletions(-)

jump to
M src/systray/systraybar.csrc/systray/systraybar.c

@@ -29,7 +29,6 @@ #include <X11/extensions/Xdamage.h>

#include <X11/extensions/Xcomposite.h> #include <X11/extensions/Xrender.h> - #include "systraybar.h" #include "server.h" #include "panel.h"

@@ -342,9 +341,9 @@ const TrayWindow * traywin_a = (TrayWindow*)a;

const TrayWindow * traywin_b = (TrayWindow*)b; if (traywin_a->empty && !traywin_b->empty) - return 1; + return 1 * (systray.sort == SYSTRAY_SORT_RIGHT2LEFT ? -1 : 1); if (!traywin_a->empty && traywin_b->empty) - return -1; + return -1 * (systray.sort == SYSTRAY_SORT_RIGHT2LEFT ? -1 : 1); if (systray.sort == SYSTRAY_SORT_ASCENDING || systray.sort == SYSTRAY_SORT_DESCENDING) {

@@ -603,7 +602,18 @@ // we end up in this function only in real transparency mode or if systray_task_asb != 100 0 0

// we made also sure, that we always have a 32 bit visual, i.e. we can safely create 32 bit pixmaps here TrayWindow* traywin = t; - traywin->render_timeout = 0; + // wine tray icons update whenever mouse is over them, so we limit the updates to 50 ms + struct timespec now; + clock_gettime(CLOCK_MONOTONIC, &now); + struct timespec earliest_render = add_msec_to_timespec(traywin->time_last_render, 50); + if (compare_timespecs(&earliest_render, &now) > 0) { + traywin->render_timeout = add_timeout(50, 0, systray_render_icon_now, traywin, &traywin->render_timeout); + return; + } + traywin->time_last_render.tv_sec = now.tv_sec; + traywin->time_last_render.tv_nsec = now.tv_nsec; + traywin->render_timeout = NULL; + if ( traywin->width == 0 || traywin->height == 0 ) { // reschedule rendering since the geometry information has not yet been processed (can happen on slow cpu) systray_render_icon(traywin);

@@ -698,9 +708,8 @@

void systray_render_icon(TrayWindow* traywin) { if (FORCE_COMPOSITED_RENDERING || server.real_transparency || systray.alpha != 100 || systray.brightness != 0 || systray.saturation != 0) { - // wine tray icons update whenever mouse is over them, so we limit the updates to 50 ms - if (!traywin->render_timeout) - traywin->render_timeout = add_timeout(50, 0, systray_render_icon_now, traywin, &traywin->render_timeout); + if (!traywin->render_timeout) + systray_render_icon_now(traywin); } else { // Pixmap pix = XCreatePixmap(server.dsp, server.root_win, traywin->width, traywin->height, server.depth);
M src/systray/systraybar.hsrc/systray/systraybar.h

@@ -14,6 +14,8 @@ #include "common.h"

#include "area.h" #include "timer.h" #include <X11/extensions/Xdamage.h> +#include <time.h> +#include <sys/time.h> // XEMBED messages #define XEMBED_EMBEDDED_NOTIFY 0

@@ -47,6 +49,7 @@ timeout* render_timeout;

int empty; int pid; int chrono; + struct timespec time_last_render; } TrayWindow;
M src/util/timer.csrc/util/timer.c

@@ -49,10 +49,7 @@ };

void add_timeout_intern(int value_msec, int interval_msec, void(*_callback)(void*), void* arg, timeout* t); gint compare_timeouts(gconstpointer t1, gconstpointer t2); -gint compare_timespecs(const struct timespec* t1, const struct timespec* t2); int timespec_subtract(struct timespec* result, struct timespec* x, struct timespec* y); -struct timespec add_msec_to_timespec(struct timespec ts, int msec); - int align_with_existing_timeouts(timeout* t); void create_multi_timeout(timeout* t1, timeout* t2);
M src/util/timer.hsrc/util/timer.h

@@ -66,4 +66,7 @@

/** Callback of all expired timeouts **/ void callback_timeout_expired(); +gint compare_timespecs(const struct timespec* t1, const struct timespec* t2); +struct timespec add_msec_to_timespec(struct timespec ts, int msec); + #endif // TIMER_H