all repos — fluxbox @ 073065ac56b388db1169108d44f37d32f1d19c67

custom fork of the fluxbox windowmanager

more fixing up of alpha zero-relatd problems - particularly fallback to
255, not zero for alpha items
rathnor rathnor
commit

073065ac56b388db1169108d44f37d32f1d19c67

parent

ca307efe3e719fbc3917ae54af4e2243ae0e4044

M ChangeLogChangeLog

@@ -2,7 +2,9 @@ (Format: Year/Month/Day)

Changes for 0.9.10: *04/05/24: * Fix handling alpha value of zero (Simon) - FbWindow.cc + - also fix up defaulting of missing alpha theme items to 255 + FbWindow.cc ToolbarTheme.hh/cc IconbarTheme.cc ToolTheme.cc + FbWinFrameTheme.cc *04/05/21: * fluxbox-generate_menu: Updated polish locales from: Łukasz Wrzosek (unl at poczta dot fm)
M src/FbWinFrameTheme.ccsrc/FbWinFrameTheme.cc

@@ -19,7 +19,7 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING

// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER // DEALINGS IN THE SOFTWARE. -// $Id: FbWinFrameTheme.cc,v 1.17 2004/01/11 16:13:09 fluxgen Exp $ +// $Id: FbWinFrameTheme.cc,v 1.18 2004/05/24 15:30:52 rathnor Exp $ #include "FbWinFrameTheme.hh" #include "App.hh"

@@ -105,8 +105,10 @@ return true;

} else if (item.name() == "window.label.active.textColor") { return FbTk::ThemeManager::instance().loadItem(item, "window.label.unfocus.textColor", "Window.Label.Unfocus.TextColor"); + } else if (item.name() == "window.alpha") { + *m_alpha = 255; + return true; } - return false; }
M src/IconbarTheme.ccsrc/IconbarTheme.cc

@@ -20,7 +20,7 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING

// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER // DEALINGS IN THE SOFTWARE. -// $Id: IconbarTheme.cc,v 1.9 2004/04/26 15:04:36 rathnor Exp $ +// $Id: IconbarTheme.cc,v 1.10 2004/05/24 15:30:52 rathnor Exp $ #include "IconbarTheme.hh" #include "FbTk/App.hh"

@@ -99,7 +99,10 @@

} else if (item.name() == m_name + ".unfocused.textColor") { return tm.loadItem(item, "window.label.unfocus.textColor", "Window.Label.Unfocus.TextColor"); } else if (item.name() == m_name + ".alpha") { - return tm.loadItem(item, "toolbar.alpha", "Toolbar.Alpha"); + if (!tm.loadItem(item, "toolbar.alpha", "Toolbar.Alpha")) { + *m_alpha = 255; + } + return true; } return false;
M src/ToolTheme.ccsrc/ToolTheme.cc

@@ -20,7 +20,7 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING

// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER // DEALINGS IN THE SOFTWARE. -// $Id: ToolTheme.cc,v 1.5 2004/01/13 14:41:32 rathnor Exp $ +// $Id: ToolTheme.cc,v 1.6 2004/05/24 15:30:52 rathnor Exp $ #include "ToolTheme.hh"

@@ -48,9 +48,11 @@ return FbTk::ThemeManager::instance().loadItem(item,

"toolbar.justify", "Toolbar.Justify"); } else if (item.name().find(".alpha") != std::string::npos) { - return FbTk::ThemeManager::instance().loadItem(item, - "toolbar.alpha", - "Toolbar.Alpha"); + if (!FbTk::ThemeManager::instance().loadItem(item, + "toolbar.alpha", + "Toolbar.Alpha")) + *m_alpha = 255; + return true; } return false;
M src/ToolbarTheme.ccsrc/ToolbarTheme.cc

@@ -19,7 +19,7 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING

// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER // DEALINGS IN THE SOFTWARE. -// $Id: ToolbarTheme.cc,v 1.14 2004/04/26 15:04:37 rathnor Exp $ +// $Id: ToolbarTheme.cc,v 1.15 2004/05/24 15:30:52 rathnor Exp $ #include "ToolbarTheme.hh"

@@ -55,7 +55,6 @@ m_height(*this, "toolbar.height", "Toolbar.Height"),

m_button_size(*this, "toolbar.button.size", "Toolbar.Button.Size") { // set default value *m_bevel_width = 0; - *m_alpha = 255; *m_shape = false; *m_height = 0; *m_button_size = -1;

@@ -63,6 +62,14 @@ }

ToolbarTheme::~ToolbarTheme() { +} + +bool ToolbarTheme::fallback(FbTk::ThemeItem_base &item) { + if (item.name() == "toolbar.alpha") { + *m_alpha = 255; + return true; + } + return false; } void ToolbarTheme::reconfigTheme() {
M src/ToolbarTheme.hhsrc/ToolbarTheme.hh

@@ -19,7 +19,7 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING

// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER // DEALINGS IN THE SOFTWARE. -// $Id: ToolbarTheme.hh,v 1.10 2003/10/13 23:47:38 fluxgen Exp $ +// $Id: ToolbarTheme.hh,v 1.11 2004/05/24 15:30:52 rathnor Exp $ #ifndef TOOLBARTHEME_HH #define TOOLBARTHEME_HH

@@ -41,6 +41,8 @@

inline const BorderTheme &border() const { return m_border; } inline const FbTk::Texture &toolbar() const { return *m_toolbar; } + + bool fallback(FbTk::ThemeItem_base &item); inline int bevelWidth() const { return *m_bevel_width; } inline bool shape() const { return *m_shape; }