all repos — fluxbox @ 65e06542491375953a481aee3f99ad412721b2d4

custom fork of the fluxbox windowmanager 

Fix typo / editor bug or something like that.

While running code analysis tools this issue popped up. As it is written it is
clearly a NOP, but the reason for why it is written that way remains unknown.
I suspect that it was a textfragment introduced by some repeat-function of the
used editor (think '.' in VIM). The code was introduced by commit a932a7a801
and looked like this in the original form:

   if(!XQueryTree(FbTk::App::instance()->display(), window().window(),
                  &root_return, &parent_return,
                  &children_return, &nchildren_return))
       parent_return=parent_return;//return;

Look at the outcommented return statement. I decided to return from that
function instead of the NOP.
Mathias Gumz akira@fluxbox.org
commit

65e06542491375953a481aee3f99ad412721b2d4

parent

bd519dd95200aa432fb3b431a4244ffb25c5de93

1 files changed, 1 insertions(+), 1 deletions(-)

jump to
M src/FbTk/Container.cc → src/FbTk/Container.cc 
@@ -129,7 +129,7 @@ 
     // get the root window
     if (!XQueryTree(display(), window(),
                     &root_return, &parent_return, &children_return, &nchildren_return))
-        parent_return = parent_return;
+        return false;
 
     if (children_return != NULL)
         XFree(children_return);