all repos — fluxbox @ bca59851f396ecb10bfbb13e60e17395490167e5

custom fork of the fluxbox windowmanager 

bugfix: crash when cleaning up signals

22fa5f544b35 was not fixing anything, the real cause is that the
SignalHolder still has a reference to a not existing Tracker.
Mathias Gumz akira at fluxbox dot org
commit

bca59851f396ecb10bfbb13e60e17395490167e5

parent

615e9cec3223d7f4661d2b2140661839929cef5d

1 files changed, 9 insertions(+), 10 deletions(-)

jump to
M src/FbTk/Signal.hh → src/FbTk/Signal.hh 
@@ -117,7 +117,6 @@ }
 
     SlotID connect(const SlotType& slot) {
         return SignalHolder::connect(slot);
-
     }
 };
 

@@ -243,8 +242,14 @@ }
 
     /// Leave tracking for a signal
     /// @param id the \c id from the previous \c join 
-    void leave(TrackID id) {
+   void leave(TrackID id, bool disconnect = false) {
+       // keep temporary, while disconnecting we can
+       // in some strange cases get a call to this again
+        ValueType tmp = *id;
         m_connections.erase(id);
+        if (disconnect)
+            tmp.first->disconnect(tmp.second);
+        tmp.first->disconnectTracker(*this);
     }
 
     /// Leave tracking for a signal

@@ -253,8 +258,7 @@ template <typename Signal>
     void leave(Signal &sig) {
         Iterator it = m_connections.find(&sig);
         if (it != m_connections.end()) {
-            it->first->disconnect( it->second );
-            m_connections.erase(it);
+            leave(it);
         }
     }
 

@@ -263,12 +267,7 @@ void leaveAll() {
         // disconnect all connections
         for ( Iterator conIt = m_connections.begin();
               conIt != m_connections.end(); ++conIt) {
-            // keep temporary, while disconnecting we can
-            // in some strange cases get a call to this again
-            ValueType tmp = *conIt;
-            m_connections.erase(conIt);
-            tmp.first->disconnect(tmp.second);
-            tmp.first->disconnectTracker(*this);
+            leave(conIt, true);
         }
     }