all repos — fluxbox @ ea9f80399b4b0468b1c91acda3b5087b042e1673

custom fork of the fluxbox windowmanager

fix crash when trying to set the title on a window that's already closed
Mark Tiefenbruck mark@fluxbox.org
commit

ea9f80399b4b0468b1c91acda3b5087b042e1673

parent

8e97963e4211963f960c52c8a8f4bf5cd135ad2f

2 files changed, 10 insertions(+), 1 deletions(-)

jump to
M ChangeLogChangeLog

@@ -1,4 +1,9 @@

(Format: Year/Month/Day) +Changes for 1.1.2 +*08/09/18: + * Fix crash when using SetTitleDialog on a window that's been closed (Mark) + CurrentWindowCmd.cc +----------------------------- Changes for 1.1.1 *08/09/14: * Fixed a minor pixmap resource leak (Henrik)
M src/CurrentWindowCmd.ccsrc/CurrentWindowCmd.cc

@@ -467,12 +467,16 @@ fbwindow().moveToLayer(m_layer);

} namespace { -class SetTitleDialog: public TextDialog { +class SetTitleDialog: public TextDialog, public FbTk::Observer { public: SetTitleDialog(FluxboxWindow &win, const string &title): TextDialog(win.screen(), title), window(win) { + win.dieSig().attach(this); setText(win.title()); } + + // only attached signal is window destruction + void update(FbTk::Subject *subj) { delete this; } private: void exec(const std::string &text) {