dont show titlebar if window is maximized

for keyboard-driven workflows with top-panels; also set tabs to the bottom of a window for best effect

add colorspace fix for window borders with transparency

Add RelativeSmart documentation to the asciidoc source. Thanks to
Alexey Ugnichev for pointing out its disappearance.

Patch from Thomas Luebking

Documents Opaque Resizing and adds a fancy config menu item

Patch from Glen Whitney

A priori, there is no reason why the workspace warping functionality should
treat the horizontal and vertical directions at all differently. Even if
traditionally horizontal warping was more common, for some in recent times
as aspect ratios tend to become larger, stacking virtual workspaces
vertically may make more sense. Similarly, some might want to traverse
an array of workspaces in column-major, rather than row-major, order.

Prior to this commit, there were extra parameters for vertical warping (a
controlling flag and an offset for how many workspaces to jump) as opposed
to horizontal warping. Also it was impossible to allow vertical warping while
disallowing vertical warping.

This commit makes all of the parameters and behavior for horizontal and
vertical warping equivalent. For backwards compatibility, there is an
overarching flag controlling whether warping occurs at all, as well as a
separate control flag and offset for each of horizontal and vertical warping.

The relevant init file resources and default values are:

session.screen0.workspaceWarping: true
session.screen0.workspaceWarpingHorizontal: true
session.screen0.workspaceWarpingVertical: true
session.screen0.workspaceWarpingHorizontalOffset: 1
session.screen0.workspaceWarpingVerticalOffset: 1

Patch from Thomas Luebking

Adds (secret) opaque resize mode. It sure would be nice if it was documented....

The relevant init file resources and their default values are:

session.screen0.opaqueResize: False
session.screen0.opaqueResizeDelay: 40

Patch from Denis Gantsev

Fluxbox would segfault when no fonts were available. Now it just exits with an error.

Patch from Dmytro Bagrii

Fix fbrun completion search for last directory in PATH

Patch from Bo Simonsen.

Improve switching between 12H and 24H in Clock Tool
 configuration

Having:

    session.screen0.strftimeFormat:	%d-%m-%y %02k:%M

The switch[1] between 12H and 24H did not work due to the digits (02).

Patch from Bo Simonsen.

Max size per client (setMaxSizePerClient) was computed for
iconbar.alignment = Relative not taking into account that a fixed size
can be given when iconbar.alignment = Left/Right.

In a "recent" change, relative alignment was changed, to better handle
items with long titles. This is breaking existing behavior, the new
behavior is (with this commit) now denoted RelativeSmart.

nls/fr_FR: Fix encoding

The encoding of nls/fr_FR/Translation.m is UTF-8 (see 96c52db). This
commit puts the correct "codeset" into place.

Move the systray ordering documentation to the asciidoc file

The .in file is generated from the .txt file.

Handle sizehint base_width / base_height being less than 0

Some applications supply -1 in base_width / base_height. One example is
the Preferences dialog of pcmanfm-qt:

WM_NORMAL_HINTS(WM_SIZE_HINTS):
  ...
  program specified base size: -1 by -1

Without this commit the program will crash due to overflow of unsigned int.

Synchronize manpages .in files with their .txt files

The .in files are generated from the .txt files.

Reformat a paragraph in doc/asciidoc/README.txt

Update xmlto URL

fedorahosted.org was retired on March 1st, 2017.

Add description of the system tray ordering to the fluxbox(1) manpage

Add missing scope to a method definition

Remove branch readme (easier merging).

Corrected typo in github-readme.

Const ref instead of const for string vector.

Ignore case when matching window classnames.

Corrected comment (now member and returns nothing).

Use FbTk::StringUtils instead of own tokenizer.

Sort on remove isn't needed.

Icon order now is property of the SystemTray.

This way it is only parsed once in the constructor. Updating the
TrayWindow order is now a method which is called once when the icon is
created.

sortClients/rearrange is now only called on adding and removing icons.

XFree must not be called with 0.

Thought BadWindow was a return status on failure.

In fact its 0, thats why fluxbox sometimes crashes when freeing the
malformed structure.

Branch specific readme.

Store order in TrayWindow instead of using expensive comperator.

Use XFree to free memory (not the default "delete").

Make systray icon pinning available.

The user options screenname.systray.pinLeft and
screenname.systray.pinRight in .fluxbox/init are read as comma sperated
list of window classnames.

While preserving the order of the lists, systray icons are sorted so
that pinLeft'ed classnames appear left and vice versa.

explicitly expect unsigned int

This fixes:

src/FbTk/XftFontImp.cc: In member function ‘virtual bool FbTk::XftFontImp::load(const string&)’:
src/FbTk/XftFontImp.cc:81:53: error: no matching function for call to ‘max(unsigned int, int)’

vim syntax: Add ftdetect to Vimball creation in Makefile

added 3rd/vim/syntax/fluxstyle.vim

zero check now uses std::max()

removed potential division by zero with size zero fonts

Fix menu docs, esp. items allowed in window menu

Update Vietnamese translation

fbrun, add horizontal padding option

fbtk, textbox, support horizontal padding

-add 'setPadding' function

fbtk, textbox, overflow selection deselection

changes the selection's deselection mechanism for oversized (e.g
larger than window width) text

new behaviour ensures the maximum selection width remains whilst
the selection length is 'oversized'. only when the selection length
has a width less than the window width will the selection (i.e. the
highlight / inverted colours) reduce in size

this is in contrast to the existing approach which would immediately
decrease an oversized selection down to nothing visually, leaving
the remainder of the selection 'off screen'. this 'looks like nothing
is selected' when in fact it is, gives a poor UX

fbtk, textbox, fix selection release on click

fbtk, textbox, limit selection height to font size

fbtk, textbox, fix cursor position and size

-use font height for cursor
-prefer 'descent to ascent' coverage as opposed to 'baseline plus
way too high'!

fbtk, textbox, fix text vertical centering

Fix evaluating variables in ExportCmd

Don't evaluate trusted variables in *ExportCmd::parse as they will be
always false for SetEnv, Export and SetResourceValue and never executed
via fluxbox-remote.

rm not needed newlines

Rotate toolbar button on rotated toolbar

In 393ba45f91480bb10f510248837c6051b7ff6a03 added the possibility to
add custom buttons to the toolbar. However, if the toolbar is rotated
the buttons stays horizontal.
Update the button to rotate the text and update the width/height of the
button if rotated

Support 'vertical' Workspace warping

'Vertical' Workspace warping is a variant of the existing Workspace
warping feature: When a user drags a window to the edge of the Screen,
the window is warped to the next / previous workspace.

'Vertical' Workspace warping detects a drag towards the upper / lower
border of the screen and warps the current workspace about an 'offset'.
Example given, lets say the user has 9 workspaces and considers them to
form a 3x3 grid:

  +-+-+-+
  |1|2|3|
  +-+-+-+
  |4|5|6|
  +-+-+-+
  |7|8|9|
  +-+-+-+

An 'offset' of 3 warps from workspaces 2 to workspace 5 (or 8), when a
window is dragged to the bottom / top border.

New configuration ressources:

    session.screenN.workspacewarpingvertical: true
    session.screenN.workspacewarpingverticaloffset: X

Merge documentation

vim syntax: Recognize fluxbox files

slit: Add missing header

Signed-off-by: Petr Vorel <pvorel@suse.cz>

update da_DK translations

https://sourceforge.net/p/fluxbox/patches/215/

stop focus cycling on explicit workspace changes

Otherwise implicit focus changes by the workspace change would be
perceived as focus stealing and the focus restored to the last window on
the original desktop

delay repositioning of labels

The iconbuttons delay their update to cover multiple changes, so if the
labels are repositioned early, they'll operate on dated titles

BUG: 1155

On the run, centralize the delay value in IconButton::updateLaziness()

remove dead switch from help

add automake helpers to enforce --std=cxx11

switching to std::unique_ptr<> in 52c9f62 caused some trouble for
users of "older" compilers: they needed to add the --std=cxx11 flag
by hand. to make life more convenient, m4/ax_cxx_compile_stdcxx.m4
and m4/ax_cxx_compile_stdcxx_11.m4 are added to do the right thing.

in my tests, the last "good" compiler is gcc-4.8, gcc-4.7 does not
support the required c++11 standard.

clang++-3.5 also works.

prevent range overflow

whenever dealing with unsigned, there's better no "-" in the line ...

Make preferredWidth max from un- and focused width

This is notably an issue if the focused font differs from the unfocused
font (eg. is bold or bigger)

Updating the value with the state leads to ugly judder (nasty when minimizing
a window through the iconbar) and not handling this causes random button
widths (depending on whether the button was focused when checking the value)

attempt a more fair container item squeezing

Ein Schrumpffreibetrag, faktisch schon Kommunismus ;-)

When short on space, items would be squeezed evenly, but this can turn
"a" and "a very long item with useless information text" into
"a very long item" and "", so in a pre-pass we check whether some very
large items cause the shortage and preferably squeeze them.

compress resize signals

typically buttons will call for this quite some, eg. when switching
workspace or (now) when altering the focused window. This compresses
various changes happening at the same time and re-layout the toolbar
only once for them

"the least oversight", part #2

playing with the side borders I figured that clicking them
(after ading them ;-) would freeze the pointer.

In addition harden the menu-triggering paths for slit and toolbar.
The menu will implicitly grba/release stuff, but in case it fails to
show up .... better safe than sorry.

escape special chars in filenames

This follows the escaped chars in bash completion and allows to pass
filenames with spaces etc.
Using quotes would be another option but requires special handling of
"~" and, what's worse, either hand-correcting the cursor position (into
the quoted area) or more completion mumbo-jumbo to handle the quotes.

fix segfault when completing ~ or .

ie. w/o any / in the given path we'll get an irregular split point and
thus out of bounds array access

document generic toolbar buttons

show tooltips for tabs

on the run (yes sucks, sorry) fixes a bug where windows were not
activated on hovering the tab (for focus-follows-mouse policies)

REQUEST: 95

The iconbar already shows tooltips and I doubt the claim that (untabbed)
titlebars are "often" too short for the window title.

allow to drag tabs to other workspaces

We simply re-use the move code.
The major pitfall is that we must not unmap the dragged window, since it
holds a pointer grab (which will break by unmapping it, so we fail to
continue or finish the tab drag)
Instead, the window is always send to the current workspace and if
detached, all other clients in the group are send back to their original
desktop.

REQUEST: 234

implement ON_SLIT actions

On the run, make it raise on left-clicks (like the toolbar)

The enum already existed ;-)

REQUEST: 113

support OnWinButton, OnMinButton & OnMaxButton

... actions in keys.
This allows to override the default behavior as well as adding actions
for the mouse wheel.
Special casing of the two "geometry" related buttons (eg. to perform
smart maximization, reverse the partial maximzation, add shading to the
min button or whatnot)
All other buttons have a rather dedicated meaning and are only really
interesting for adding mouse wheels or eg. the window menu on rmb
clicks.

Needs docu.

button: export pressed state and assigned commands

latter protected only.

"the least oversight" #1

The fixes a permanent (sync) button grab.

Well, oversaw global buttonpresses.
Let's wait for more to come ;-)

only call applySizeHints when desired

passing the "make_fit" parameter isn't sufficient to ignore constraints

resolve handle/grip context conflict

fix window placement documentation

introduce autotabplacement

Do not break server grabs

We have a nifty counter-based grab, so use it

std::auto_ptr to std::unique_ptr

Improve utf-8 support

Operate on inverse iscntrl check which allows us to avoid wide character
conversions.

support ctrl+a for selecting all

Support editing utf-8 text in TextBox

aka "Flüxbøx"

βµγ, pardon,
BUG: 720

document iconified title deco

Next|PrevWorkspace 0 toggles former Workspace

REQUEST: 185
also PATCH 92

hide menus when clicking title or toolbar

BUG: 1149

allow 4px deadzone for clicks

For the shaky ones.
Since this introduces a visible gap between trigger and move event, we
temporarily manipulate the coordinates in the global last event what
covers the outdated patch #134

REQUEST: 178

remove tabs

translation:fr_FR adding -no-slit, -no-toolbar and minor fixes

apply  back the copyright to Fluxbox Team
these are changes from commit bf3714e12456c2dd361ded47854546d2a0606403

translation:fr_FR updating $ set 9 #keys

based on C, de_DE and es_ES

fix display $WPSETTER

BUG: 1031

handle DISPLAY :x and :x.0 idem

Patch originally provided by Francesco Poli to Debian

BUG: 1052

handle subdirs and symlinks in $wallpaperdir

Thanks for the base patch, kindly provided by some Anonymous coward
on the bugtracker ;-)

BUG: 1065

Update Translation.m

indicate iconified windows in iconbar

do not confine transients to desktop layer

Originally patch #170 by gregor_b
Desktop stype windows will typically have their config dialogs as
transients. If those are confined to the desktop layer, they're stashed
behind everything else, so we don't force them there.

If the transient already is in the desktop layer otherwise it's a(nother)
desktop, not a dialog, and belongs to that layer, there's no need to
artificially raise it.
It's entirely sufficient to leave these windows untouched.

delay mouse driven tab focus by autoraise interval

REQUEST: 190

expose and fix ActivateTabCmd

The function failed if the last event window was actually the tab.

re-use position sanitization for modal placement

introduce a 5s timeout for emacs shortcuts

The user needs to enter his chain within 5 seconds
Otherwise the chain is reset.

REQUEST: 291

Relative aligmment when changing window head

So far, altering the head would potentially move the window
out of the workspace area (by moving a far right/bottom window from a
HUUUUUGE to a small screen)

This preserves edge alignments (w/ topleft preference), otherwise
moves the window to it's relative topleft position on the new head
(ie. if it was 10% left and 3% top into the screen, it will still be)

Add "Unclutter" command

Unclutter the desktop by using the MinOverlapPlacement
for all matching windows.

REQUEST: 248

Don't replay presses which are required f/ motions

When trying to doAction(ButtonPress, ...), we check whether the
action would hit for type==MotionNotify.
In this case we do nothing but return "true" to tell the caller that
this event is "for us". Otherwise the event would be replayed to the
client and there'd go out MotionNotify grabs.

tl;du: This fixes MoveX actions.

fix compiler warning about std::auto_ptr

fluxbox uses std::unique_ptr<> where it previously used std::auto_ptr<>.

C++0X was approved in 2011. among other things, it deprecates std::auto_ptr.
5 years is long enough for compilers to catch up the standard.

Grab keyboard synchronouosly to allow replays

This allows to catch if a grabbed key (combo) is actually w/o effect
(because eg. the OnDesktop condition does not match) and then replay
the event ungrabbed to pass it to the focused client.

Just like mouse grabbing, this BEARS THE POTENTIAL TO LOCK INPUT, thus
needs AS MUCH TESTING AS POSSIBLE

BUG: 1137

Replay toolbar button events

NOTICE!!!! THIS IS HIGHLY EXPERIMENTAL!

The patch alters the button grab mode to GrabSync
in order to ReplayPointer the event.
THIS CAN FREEZE ANY INPUT TO FLUXBOX!!!

The toolbar (and other things?) grab buttons in order to
handle MouseN events for the entire bar, INCLUDING all child
windows.

This causes two problems:
1. The bar handles events which are not meant for fluxbox at all
   (but the systray icons)
BUG: 940

2. The bar will intercept (and suck) *every* press, even if only
   doubleclicks are desired
BUG: 949

The problem with this patch is that an oversight here has the potential
to completely freeze input event processing in fluxbox (ie. the process
needs to be killed from outside), SO IT NEEDS TESTING!
As much as possible.

fix titlebar ClickN handling

the tabcontainer is usually true and the releases were only
handled for the WINDOW context.

This relies on the patch to control OnTitlebar ./. OnWindow !

BUG: 1073

Control OnTitlebar ./. OnWindow

On concurrent shortcuts OnTitlebar implies OnWindow and was so
far resolved to OnWindow while OnTitlebar is the more precise
condition.

This also requires to exclude buttons from the titlebar context,
ie. pass the position to the getContext function on press events

BUG: 1035

The patch depends on the patch to correctly resolve the tab under the
mouse since we're now passing the actual subwindows around

Search actual tab under mouse

The feature suggests to behave like this bug actually only supported
mouse clicks (because the latest event window needed to be the tab)
This condition will break with two future patches (OnTitlebar context
selection and Sync Pointer grabbing) so the code to determine the tab
client needs to be a bit more sophisticated and, as a bonus, keyboard
shortcuts to activate the tab under the pointer will work as well =)

add apps key to ignore XSizeHints

BUG: 1075

apply size hints when applying the state

There's a setting about maximization which allows to control whether the
resize increments should be honored when maximizing windows.
This is currently used to control whether maximized windows may resize
themselves via (rare) configure events, but not when maximizing windows
- what's somehow not what the config item sells.

BUG: 914

handle oversized windows

Clients can still be stupid (feh constrains itself to the root window
...) or lazy (llpp uses the last size - if that was in pivot mode ...)
and create windows which exceed the workspace dimensions, resulting in
both opposing edges being off-screen (for all tested placements)

This applies partial maximization instead and resizes the (restored)
window to soem sane size (size constraints applied)

CCBUG: 688
CCBUG: 984

catch absurd but possible div-by-zero

emit resize signal when altering the iconbar mode

Otherwise the iconbar would be capped when showing more (eg. all instead
of iconified) windows

Grab Server when showing or switching desktop

Should reduce exposure events, notably since the
windows are not in stack order.

XAllowEvent's for CurrentTime

ML confirms that be.time seems to be dated or junk and
causes permanent freezes. Seen such myself but couldn't
sufficiently reproduce to pin a culprit.

allow to alter button labels via fluxbox-remote

Command is "RelabelButton button.foo $LABEL"

This is useful to eg. hint the amount of unread mails in a
button to start your MUA, reflect the $USER in a session menu button
etc.

toolbar: allow labeled general action buttons

With this patch you can add buttons like
*.toolbar.button.foo.label: F
*.toolbar.button.foo.commands: RootMenu:Exec foo
*.toolbar.tools: button.foo, iconbar, ...

button.*.label is mandatory
button.*.commands suppots 5 mouse buttons, but the way
stringtok works, it's required to add a blank
(or some junk) between to colons to skip a button

support FbTk::TextButton's in ButtonTool

required to allow labeled general action
buttons in the toolbar

add functions to toggle slit/toolbar hidden

Fix autohiding/raising timer logics

Trying to control a timer bound to an unconditional toggle, caused by
opposing events does not work. <- That's a period.
The toolbar implementation would act too seldom, the slit to often.

Instead, fire the timer whenever the state does not match the event and
bind it to a function that queries the pointer position and acts
accordingly.

add autoraising to toolbar and slit

add commands to toggle toolbar and slit layer

toggle(Toolbar|Slit)Above toggles the resp. item between its
regular and the AboveDock layer (ie. above everything, even visible on
active fullscreen windows)

Also required step for autoraising.

REQUEST: 222

add support for artificial struts (per head)

Allows to maintain access to desktop fractions etc. against
maximized windows. Also permits to OnToolbar clicks in this case, eg. to
raise it.

REQUEST: 150

Improve stretching (RELATIVE) toolbar items

The available space is distributed reg. the preferred width
of items (spacers and the iconbar ;-) instead of evenly.

The preferred width of the iconbar is calculated from its buttons.

This allows to align the iconbar using spacers and makes better use of
the available space

Adjust RELATIVE ::repositionItems (more relative)

The evenly distributed space causes a lot of whitespace and otoh. cut
items, so we use the items internal size as indicator IF the item is a
textbutton (the regular usecase in fluxbox)

Also publish the function to be triggered from outside (because the
caller can, in theory, much better compress several text changes)

expose a preferredWidth of *Button's

delay title updates

Notably shells will cause brief interim titles when calling
short-lived commands (try "ls"...)
This covers such by waiting 100ms after every title update before
reacting (the title will have returned in the mentioned cases, the UI
remains steady)

signal title changes

so that interested parties (the iconbar ;-) can use/forward them

Add SpacerTool

This allows to add random spacers, fixed size or stretching, to the toolbar.

CCBUG: 1141

flag slit for reconfiguration and act on show

According to Peter Ganzhorn, there's a transparency issue when using an
autohiding slit, but I don't use a slit at all.
However, the explanations in the bug do make sense and this is just an
alternative approach on the problem (that does not require interim
showing)

BUG: 1132

fix transient dialog placement

dialogs can be bigger than the mainwindow and the unsigned dimensions
then overflow in the subtraction (the window would still be moved into
screen bounds but appear on ugly 0,0)

hide window before restoring the client on unmaps

otherwise compositors will update the texture and operate on (fade) the
frame instead of the client.
Didn't test why this only happens on ARGBs, but could be the colormap
installation.

BUG: 1110

reposition visible submenus when changing style

a fixed position of the style menu won't help (the menu geometry changes
*because* the item geometries do) - warping the pointer would likely be
possible, but warping the pointer is cc. "evil"

BUG: 715

reconfigTheme's on loading a new style

Also reconfigure menus (recursively) on style load
The most critical call is the shape update - the menus often become
cut-off, preventing mouse interaction with lower items, but also colors
are not applied correctly to menus w/o updating them.

BUG 1022 is most likely this and only a misinterpretation (for the
mentioned items are those with lacking color updates on style updates)

BUG: 1146
BUG: 1017
CCBUG: 1022

handle both Focusable's as m_cycling_next

m_cycling_next can either be WinClient or a FluxboxWindow
In case of the latter, client->fbwindow() needs to be matched in
setFocusedWindow when protecting against client side focus juggling.

BUG: 1148

explicitly set s_focusedWindow for cycle protection

Do not reset cycle focus when unsetting focus only

Do not protect focus while cycling

We've better things to do and the focus is moving around anyway
BUG: 1048

do not lock focus against unfocusing.

Latter happens when eg. closing windows, including such with
locked focus

prefer m_cycling_next over s_focused_window

as cycle start (former is where we wanted to go and X11 is still async)

allow to force moveResize and use on applyState

applyState also requires some updates implied by moveResize, notably the
reconfigure, the setBackground on the window etcetc.
Instead of testing what'd be missing from a moveResize, we just force
the latter to apply even when seeming unrequired.

This has notable impact when switching fullscreen state for a window
with fullscreen dimensions.

BUG: 992

add support for dedicated completion data

This allows to complete random things, useful along the -print flag but
also to limit the commands to those found my menumaker etc.

Allow to center fbrun

While any window can be centered using the apps file, fbrun can serve many
purposes and sometimes (runner) makes sense being centered, sometimes
(button/menu triggered input) near the mouse, sometimes ("application")
regularily placed.

REQUEST: 282

limit fbrun history size

the default is 1024-1025, values are read from the FBRUN_HISTORY_SIZE
environment variable
NOTICE: the limit isn't hard, but will typically be n+1 and only n if
the new entry is already present in the last n entries

REQUEST: 202

add autocompletion support to fbrun

improve fbrun completion

- streamline code
- indicate completion by making use of selection
- fix buggy behavior (notably subsequent completions and FS path
  following)
- support "~" in paths
- support chunk completion
  (ie. "mp[layer] ~/vid[eos/favporn.mp4]" can be completed in both
   tokens; buggy with paths including spaces in non-leafs)

REQUEST: 223

clear selection on text input

Entering upcase chars would auto-select them
Seems I don't need upcase chars very often ;-)

list strict mouse focus in FOCUS POLICY section

of man 1 fluxbox.

BUG: 950

less bashisms in fluxbox-generate_menu

still works with bash or zsh, but fish (now) complains about "cat << EOF" ...

no "grep -q"
BUG: 961

echo is troublesome
POSIX doesn't know a "local" keyword
BUG: 975

seems double comments ## aren't supported everywhere
BUG: 1057

smart handling of NotifyUngrab crossing events

closing a keyboard driven popup had the sideeffect to return the focus
where the pointer is, regardless of whether that window had the focus
before (due to a NotifyUngrab crossing event), bug #597
This was resolved by simply ignoring NotifyUngrab mode crossings, but
that had the unfortunate sideeffects to break focus passing when the
mouse was actually moved (in a DnD operation, 730) or the focus shall be
passed on for strict mouse focus and a mouse triggered lower action (1012)

So instead we record the window that was last entered by a *real*
crossing and only ignore the NotifyUngrab event if this window didn't
change.

BUG: 1012
BUG: 730
CCBUG: 597

Revert "bugfix: fbsetroot needs to use 24bit visuals as well"

This reverts commit 4f4d5e25d9a0cf1fc4c0d1a8b7777a560494b7a4.

The patch resolved a problem introduced by the ::setDepth abuse in
FbRootWindow, but this fails if the root window is *really* 32bit
With commit dcdde4d, the broken workaround depth selection is no longer
required.

BUG: 1093

document "transient" section

BUG: 1092

ignore font for empty title height calculation

and align calculation on init and reconfigure

As a result, if a menu has no label, the title height is determined
only by menu.titleHeight (and the border sizes), not by the unused font.

re-fix alt+tab'bing through tabbed windows

commit 98313bf broke (i'm terribly sorry) this because m_cycling_last stores
the first client in a tabgroup, thus cannot be abused for this purpose.
So we explicitly store a value and btw. do it before sending the focus,
ie. "in time" for sure instead of "for sure™"

fix tabbing of unfocusable clients

this affects all java clients, because java uses the retarded
WM_TAKE_FOCUS protocol, but also very important clients like xeyes ;-)

BUG: 1055

do not leave stale oplock behind

deiconify'ing a client on a different workspace left an oplock by a
shortcut return, turning the client semi- to inaccessible

BUG: 1010

avoid calling into XLib

Testing one bug, the function seems usually be called with the root
window as parameter, so we can save a pointless lookup for the root of
the root by testing against window before testing against window_root.

Elegantly, this will "fix" the bug where XGetGeometry of the second
heads root will either report the first heads root or some junk (xephyr
case?)

BUG: 1128

ensure to update the current client tab from menu

the menu focuses which tries to set the current tab, but fails because
the iconified client won't have the input focus (yet), so we pass it a
dedicated "set this client and do not try to set input because we're
going to do next anyway explicitly" call =)

BUG: 997

do not move unfocused windows to the desktop layer

While usually™ the window is just reset to its original layer, ensuring
to show the active window is certainly a good idea, but it's not
required to lower the fullscreen window to the desktop layer, the other
windows layer + an extra raise is entirely sufficient and it's rather
odd to see conky when activating a utility window to a video player ;-)

CCBUG: 894

add _NET_WM_NAME to FbWindow::setName

since fluxbox is a f**** WM it should be able to use f**** NETWM hints
in its toolkit ;-)

CCBUG: 702
(does not fix input)

fix tab selection by mousepress

Tabs outside the titlebar are not selectable by mouseclicks (ie. the
feature does not work)
The patch clones the enterNotifyEvent code and ignores (for now) the
actual button (no idea whether it makes any sense to restrict it the
left button?)

BUG: 1103

document FocusProtection feature

merge remember focusnew into focusprotection

The FocusNewWindow key is still read, but not written and OVERRIDDEN in
case of conflict with the FocusProtection key

Add FocusProtection features

The apps file gets a new key
FocusProtection
supporting a comma separated list.
* None : regular behavior
* Lock : If this window has the focus, no other may claim it
* Deny : This window is not allowed to focus itself

I addition there's preparation for a follow-up patch to incorporate and
substitute the present FocusNewWindow feature:
* Gain : Pass focus to new window
* Refuse : Do not pass focus to new window

rationale:
clients stealing the focus sucks badly and while there's an input driven
timeout, that only protects actual typing flow, but if eg. vlc proceeds on
the playlist, you'll suddenly control vlc instead of your browser
(ie. typing ctrl+w doesn't close the tab, but the playlist ...)

remove strut when property is withdrawn

CCBUG: 1133

fix tracking of MWM hints in case of removal

replace FbRootWindow::depth with maxDepth

The depth member of FbWindow was abused to store the maximum depth
but that gets overridden with geometry changes of the root window
(screen layout changes) so we store and read the value explicitly while
::depth() maintains the actual depth of the root window

The result of this is that frames for ARGB windows were created with a
wrong depth and failed to reparent the client window.

BUG: 1102
BUG: 1058

prevent clients from positioning out of workspace

Still enough stupid ones around which ask for 0,0
(despite there's a panel ...) or restore a position
on a VGA screen which they stored while being on a 4k
screen.

Otoh, do not forcefully position the window just because
the topleft position is outside any head, this can still
be desired and isn't a problem.
Actually, the corner could be covered by the close button
and if *only* it is onscreen the window can hardly by used
or seen.

keep cmd menus off struts when the mouse is in it

the mouse is likely the trigger, so the popup would cover the
trigger item.
The present behavior of the iconbar suggests such behavior is
desired.

improve consistency

for a std::string::size_type, the right value to use is not "-1", but
std::string::npos.

fix broken text selection for FbTk::TextBox

uninitialized variables cause all kind of problems.

harden focus cycling against client focussing

Clients which implement a client-side modality might cause
livelocks by reverting the focus to the transient (after the
WM tried to put it on the leader as the transient's modality
is unknown)

So while cycling we revert the focus whenever it moves somewhere
where we don't expect it.
When done, we also focus the window that should have the focus anyway
to allow the client to redistribute the focus (as we prevented it
during cycling)

Hall of Shame: Softmaker Freeoffice uses (only) client side modality.

document -preselect in fbrun manpage

fix fbsetbg in combination with picky shells

in *BSD, /bin/sh is Almquist Shell(ash). the 'hash' built-in command of ash
returns 0, always. 'hash' is not usable for find_it() function in
util/fbsetbg and util/fluxbox-generate_menu.in.

this patch changes the behavior of find_it(): when 'hash' is detected to
not work correctly, switch back to 'which'.


this patch is the work of Yamashiro, Jun and appeared first as patch-160
on sourceforge: https://sourceforge.net/p/fluxbox/patches/160/. i submit
it on behalf of the author.

Fix menus over a single column wide

Fixes menus more than 1 column wide (such as the Placement menus for
the Toolbar/Slit/Tabs) which stopped working with commit 3e4570b.

Allow to preselect preset text

Allow text selection

FbTk::TextBox now acts like any contemporary input field ;-)

place transient centered on its parent

so far, transients are simply unplaced, resulting in a static
0,0 position.

Mixed relative and absolute values for apps

Allow setting relative value for x and y or width and height separately in
the apps configuration file. This makes these settings compatible with ones
available in the keys file.

Previous buggy behavior:
If someone has specified, e.g. "[Dimensions] {50% 100}" it was parsed as
"{50% 100%}" not as "{50% 100px}" which was inconsistent with the "keys"
configuration file.

From now on it is possible to write something like this:
[app]
  [Position] (RIGHT) {50% 0}
  [Dimensions] {300 100%}
[end]

Signed-off-by: Arkadiusz Bokowy <arkadiusz.bokowy@gmail.com>

fixes bug #1138

minor code cosmetics

send ConfigureNotify using root coordinates

Add documentation for edge snap feature when resizing.

Add Resize Snap

Make windows snap to edges when resizing them, as well as when moving.
From http://darkshed.net/files/patches/fluxbox/fluxbox-resize-snap-try2.diff

merge pull-request 14

fbsetbg: Report wallpaper directory path when invalid

Update MinOverlapPlacement.cc

Skip any windows which are not in the same layer as the window to be placed.

Update ColSmartPlacement.cc

Skip any window that is not in the same layer as the window to be placed.

Update RowSmartPlacement.cc

Skip any window that does not exist in the same layer as the window to be placed.

Fix hidden toolbar placement

Simplify code

* assume 'pattern' to always be lowercase
* rename some variables

Fix bug in detecting text in MenuSearch

A bug sneaked into my implementation of Boyer-Moore-Horspool. This lead
to not finding certain patterns. Given the text 'abcdde' and the pattern
'dd', the faulty implementation would not find 'dd':

1. 'ab' does not match, skip 2 (length of pattern)
2. 'cd' does not match, skip 2 (length of pattern) <- the bug.
3. 'de' does not match, end of string

The bug in step 2 is to not use 'd' to detect how far to skip but to
use 'c' (which is not in the skip-table) and thus 2 bytes are skipped).

Fix RIGHTCENTER placement of the toolbar. Instead of subtracting borderwidth (bw) from (frame.height))/2 they were multiplied causing wrong placement for this case.

Shape only toolbar corners not touching any edges of the screen. It just looks better this way.

Fix shaped toolbar being drawn incorrectly at TOPCENTER Fix round corners being drawn incorrectly on the TOP instead BOTTOM of the toolbar when toolbar placement is TOPCENTER. Also align the _values[] table a bit more nicely to make it easier to spot bugs like this. The bug was introduced in commit 67c31b49bdeab40fea37719cd6cfa06b37507e3e 'Refactor Toolbar.cc, less noise'.

roll back 7e17056: m_index does not exist anymore

m_index was removed in 03ce82a.

TextBox::textStartPos can be const.

ButtonTheme::name can be const.

Make Layer::getLayerNum() const.

Initialize m_index in MenuItem's constructors.

Reduce the scope of the variable err in stringTokensBetween.

doSubmenu function in menutest.cc avoids copying labelstr by using a const reference.

addMatching and insertFromParent functions from FocusableList now avoid copying m_parent->clientList() and use a const reference instead.

Pass pre_command to CommandDialog as const reference to avoid unnecessary copying.

Don't assume ICONV_NULL = 0

We define the value ICONV_NULL = -1, but when we attempt to set the
s_iconv_convs array to all NULL values, we zero the array instead of setting
its entries to -1.

This patch properly initializes and wipes s_iconv_convs.

Final notes

Prepare manpages for 1.3.7

Fix: typo during refactoring

Commit 63d9d69 introduced a bug, which has manifested itself by setting
window transparent state to the fully opaque (255).

Move internal code to internal side of FbTk::Transparent

Add .mailmap file

Update Turkish translation

This adds missing strings as well as fixes the typos and grammar issues.

Update ChangeLog and NEWS

Minor

Create buttons for titlebar with proper sizes

Instead of creating the titlebar buttons with a size of 10x10 pixels
and rely on resizing later on we now pick the correct dimensions
right on.

This fixes also bug #1125 ("Detaching a window from a tab-group renders
app-icon to 1/2"); the problem also occurred on restart.

I took the chance to refactor a little bit.

Fix glitch of TabOptions menu

Show toggleitems in menu

Cosmetic

Boyscouting

Fix cleaning exposed menu items

Avoid signed/unsigned woes; minor cleanup

Add uncommited #include "MenuSearch.hh"

Note to myself: less gitting at late hours.

Update documentation to reflect menu search options

Cleanup; Remove unused function

Feature: different MenuSearch modes

Fluxbox now supports three MenuSearch modes:

* NoWhere - essentially "disabling" the menu search.
* Somewhere - the search string matches somewhere.
* ItemStart - the search string matches at the start of a menu item.

The default value is "ItemStart", just in the good old times. As long as
this feature is not configurable via the menu it would irritate users
with distinct muscle memory who type without thinking OR checking the
visual feedback: they would trigger items they did not intent to trigger
after years of the old behavior.

Once this feature get's an entry in the config menu the default value
might change.

Fix problem with too small WinButtons

Under some circumstances a WinButton might be tiny (1x1 pixel). Substracting
values > 1 yields either 0 or something reaaaaly big (UINT_MAX). This will
make fluxbox either crash or make it act weird. We don't want this.

Move nls globals into #ifdef NLS

Fix crash: click the Remember-menu works again

This commit fixes a subtle regression introduced by myself in
f64727ca: WinClient wc = FbMenu::window()->winclient() creates a
copy and this copy gets cleaned up at the end of the scope. What
I really wanted was a reference.

Fix regression: use proper texture for the grips

Cosmetic

Close to 1.3.7

Improve I18n support

Among the first steps to produce better i18n support is to test the created
translations adhoc without running "make install". To achieve this, fluxbox
now honors several environment variables:

- NLSPATH: fluxbox won't create the absolute path to the catalog and thus
  catopen() is free to use NLSPATH as described in the manpage. Example
  given: "/tmp/%N" will pick "/tmp/fluxbox.cat". %N refers to FLUXBOX_CATFILE.

- FLUXBOX_CATFILE: By setting FLUXBOX_CATFILE the users can make fluxbox to
  use a different name for the catalog file.  Default: "fluxbox.cat"

- FLUXBOX_CATDIR: Per default fluxbox tries to find FLUXBOX_CATFILE at several
  places. Setting this environment variable allows to point fluxbox to a
  different search path for the catalog files.

Then, fluxbox tries catopen() first without changing the deduced catalog file
name. After that it applies some heuristics to get a good catalog file name.

Update translations: add CommonDefaultWindowMenuFile

Clean up FbTk::I18n API

Move private stuff into FbTk/I18n.cc.

Fix sometimes missing windowmenu

When the windowmenu file is empty in ~/.fluxbox/init the code falls
back to the default. In ab2eef4 I forgot to set the rc_path which
caused this bug to happen.

Add chrome* to fluxbox-generate_menu

Use strncpy() instead of strcpy()

Use strncpy() instead of strcpy()

Make fluxbox strcat() free

Again, gcc-4.2.1 of OpenBSD-5.6 pointed out the use of strcat(). I took the
chance to explain the reasons for the code a little bit.

Simpler code to set _NET_DESKTOP_NAMES

gcc-4.2.1 on OpenBSD-5.6 hinted that strcpy() is not the safest function on
earth. While seeing the code I wondered why it we first create copies
of the names at all (let alone using memset() and then strcpy() after it).

Compiler boyscouting: init order

Fix correctness of string search

The lookup for the skip value needs to be based upon the lowercase version of
the current byte.

Increase verbosity of 'configure' summary

After 'configure' finishes it states just CXXFLAGS and LIBS. But these are
actually not complete, the build system will use much more later on. Problems
with the build system are easier to address if 'configure' is a little bit
more verbose.

Fix mishandled [maxmized] statement in apps file

In f64727ca I removed one 'else' too much. As a result all [maximized] lines
were mapped to MAX_NONE. Fixed.

The rest of the commit is just some cosmetic to reduce indentation and shorten
function names, easier to read.

Feature: typeahead in menu matches text anywhere

This commit implements a tweak to the typeahead feature already existent in
fluxbox: If the user opens up a menu and starts typing, fluxbox tries to
detect matching menu items and makes them available for quick selection.
The typed pattern is now search also in the middle of the text.

I opted to strip down the code quite a bit and remove complexity by throwing
out FbTk::TypeAhead and FbTk::SearchResult because I do not see the need for a
general solution when the only use case for such a feature is in fluxbox'
menus. FbTk::ITypeAheadable shrunk down to 2 functions; the whole file might
be combined with the code that implements FbTk::Menu::TypeSearch.
FbTk::Menu::setIndex() and related code is also gone: the position of each
menu item is defined by it's position in the items container. This reduces the
mount of book keeping fluxbox has to do. Fewer moving parts is a good thing.

It's possible that users start to complaint because they expect their
typed pattern to match only at the beginning of the text OR that some
demand other tweaks. We will see.

This commit also fixes a regression introduced by 8387742c. The bug made
the menu vanish.

Fix printf bug in fluxbox-generate_menu

Add 'lxterminal' and 'geany' to fbgm

Implements #305 (feature request "Recognize lxterminal and geany
(fluxbox-generate_menu)"

Update Changelog; prepare 1.3.7

Cleanup

Improve code documentation

'width' might imply something 'aligned horizontally'. The first parameter
of maxTextLength() is given in pixels. To avoid confusion, the name of
the parameter is changed.

The comment before the binary search reflects better why and what we
need to do.

Fix text rendering in rotated TextButtons

A vertically rotated text should be checked against the height of the
button, not the width of it.

Fixes #1119 ("Toolbar cannot display full text of workspace/​clock/​window
title.")

Refactor Toolbar.cc, less noise

Refactor FbWinFrame

FbWinFrame is now simpler to read due to less overall noise.

Cosmetic

Update manpage to reflect -no-slit and -no-toolbar

Update translations to reflect new flags via -h

Add -no-slit and -no-toolbar flags

Sometimes fluxbox is used as a component of a desktop environment (
e.g., the "Lumina Desktop"). It's easier and more stable for this kind
of "users" to disable the toolbar or the slit alltogether. Why not
configure these features out? Because then they would need 2 installations
of fluxbox: One without the slit and the toolbar (and perhaps other
components) and one with them.

This implements feature request #314, at least partially.

This commit also looks bigger than it actually is: I refactored and cleaned
up classes Fluxbox and BScreen.

Prepare 1.3.7

Remove 'always true' condition

Fix broken _NET_REQUEST_FRAME_EXTENTS support

There was a subtle flaw in the way fluxbox detects to which BScreen a
given Window belongs: We have to compare the RootWindow of the given
Window against the RootWindow of each BScreen.

That underlying flaw made _NET_REQUEST_FRAME_EXTENTS fail: the code path
needs a valid BScreen for the given window, otherwise we return early.

Closes #1121.

Fix removing windows from icon list

std::remove_if() removes an item from a container and returns a
past-the-end iterator ... which equals m_icon_list.end(). As a result
the check

    if (erase_it != m_icon_list.end()) {
        iconList().erase(erase_it);
        iconListSig().emit(*this);
    }

will never succeed and thus the iconListSig() will never be emitted.

Cosmetic

Cosmetic

Fix segfault on shutdown

There was a problem deep within how the menus were connected and when and
what gets deleted. It was clearly related to a menu which was kind of
global. In order to better understand the code flow I eliminated the
ExtraMenu code: it was used only to get the Remember-Menu into the
Window-Menu. Instead of having a singleton of the Remember-Menu and fight
against the shaky interconnections we just create a new one on demand
and delete when the menu gets deleted. Looks like this fixes the problem.

The menu code needs more love anyway.

Closes #1118

Refactor: bundle related members together

Also: try to avoid unsigned/signed problems in drawing code.

Cosmetic: less code bloat

Fix potential memory leak

If allocation of I2 does not succeed, we need to free I1.

Closes #1120

Fix behavior for autorepeat keys

This reverts 58e09b719077605efadac9b712acb8f5e752f732 after having regressions
and bug reports in regards to autorepeated key events are not working anymore.

So, the problem with the lost keypress after the workspace change is still
open but at least the behavior for other folks is as it was. Since 58e09b7190
seems to be corelated to "auto repeat" keys it might indicate the problem
which 58e09b7190 "fixed". We will see.

Fixes #1115.

Minor cosmetics

Fix compile errors with clang

Remove unused variable

Fix compile error: old g++ does not like c-like struct initialization

Fix uncommited change (see 8387742c8...)

Fix casting issues

Fix uninitialized variables; cosmetics

Note: I expect only modern compilers will hit the source of fluxbox. It
seems futile to guard stdlib headers while demanding <algorithm> etc. This
should trim down the noise in the source quite a bit.

Avoid modulo 0

Coverity pointed out that 'size' might be 0 (even if the 'find()' would
detect this). This commit fixes this and avoids entering 'find()' at
all.

Make coverity happy

Coverity complaints about 'isdigit(whole_keyfile[pos])' is changing the
validity of 'keyfile' (which itself is just a copy of whole_keyfile.c_str()).

This might be a valid claim, it might be not. By using the 'keyfile'
variable we make Coverity happy and achieve the same behavior.

Fix semantic errors (wrong variable names etc)

Uncovered by coverity-scan.

Fix leak in ClientPatternTestCmd

Coverity-scan points to the leaking ClientPattern. The rest is just
cosmetics.

Refactor: bundle xinerama-info together, simpler code

Part of this massive looking but simple rather simple change is a the way we
check for active Xinerama: XineramaIsActive() was used before. The docs for
XineramaQueryScreens() state that

    XineramaQueryScreens() returns NULL and sets number to
    0 if Xinerama is not active.

Sold.

Refactor: move some menu-creation functions to MenuCreator

Another patch to trim down the code that needs to be part of BScreen

Reduce number of allocations for menu creation

Every time either the Slit menu or the Toolbar menu were added to the
root menu, the whole root menu was (re)created from scratch. Now we
create and remove only the menus needed.

Side effect: the position of these menus is now at the end of the root
menu and not somewhere in between. If users complaint, I' ll think about
it.

Refactor: split out menu generation from BScreen

Again, it's easier to read the code when the whole menu-generation is out of
the way.

Refactor menu code: be more explicit and compact

This commit is a preparation step for some menu cleanup ahead. To make it
easier to understand which types of MenuItems are added where and when, I
converted the overloaded FbTk::Menu::insert() functions into explicit ones
(Menu::insertSubmenu(), Menu::insertItem(), etc. ). This makes it possible
to just grep for 'insertSubmenu()'.

Side effect this commit: it trims down the very verbose creation of menu items
in regards to how the labels are created.

Minor: FbTk::Menu::shown and FbTk::Menu::s_focused are moved out of the class.

Fix broken formatting

Fix 'configure --help' to match actual default value

Code cleanup

Reorder some includes; remove unused includes

Make use of API instead of hardcoded default font

Fix order of reconfigure the theme of an IconButton

The font might have an impact to the result of width() and height(). In order
to render the new pixmap correctly fluxbox now first sets the font and the
width of the border and after that it recreates the pixmap.

Remove dead code

Fix bug: integer underflow in startup phase

When fluxbox comes up some of it's drawables span a 1x1 area. Subtracting from
such small numbers bigger ones always lead to massive problems when 'unsigned
int' are involved:

'button_width' is an unsigned int of '1' (this might be caused by another
issue or on purpose, anyway), subtracting -10 or any other number should
result in something < 0 when in reality an integer underflow happen: max_width
is now MAX_INT-something big. This makes fluxbox crash under certain
circumstances.

This fixes bug #1116.

Fix 'make check'

Documentation: white-spaces and minor formatting

Add ArrangeWindowsStack* actions to vim-keys

Fix build-system: link against libiconv

Some systems (BSD, MacOSX) need explicit linkage against -liconv.

Fix build-system: install data files (keys, apps, menu ...)

* Correctly build data files when operate outside of the $(srcdir)
* Actually install data files
* Use pkg-config to detect X11, works better on MacOSX. We used pkg-config
  already anyway, double checking for X11 does not yield better results.
* Replace EXEEXT in some files while before installing them

Fix build-system: use xxx_LDADD instead of xxx_LDFLAGS

xxx_LDFLAGS place the libraries like '-lX11' or '-lXft' at the beginning of
the linker command. Some systems were not able to handle the situation and
this lead to a lot of unresolved symbols. Reading the documentation of
automake:

    ... you can use LDADD to do so. This variable is used to specify
    additional objects or libraries to link with; it is inappropriate for
    specifying specific linker flags, you should use AM_LDFLAGS for this
    purpose.

In addition we link against -lm in order to satisfy symbols refering to 'cos'
and 'sin'.

Fix to make clang happy

POSIX states that 'd_name' in 'struct dirent' is char[], so it cannot be NULL.
This will result in the compiler complainting about an expression which always
evaluates to true ... for this compiler (clang). But in some implementations
'd_name' is a 'char*' that's why it's better to keep the check for possible
NULL.

Minor API change for OSDWindow

OSDWindow::resize(const FbTk::BiDiString&) shadowed FbWindow::resize(x, y). To
fix this I renamed the function to OSDWindow::resizeForText() to make the
intention clear.

Fix signature ITypeAheadable::isEnabled()

Fix signature FbTk::FontImp::rotate()

Clean unused variables

Fix clang warning 'expression with side effects'

Fix number2*() functions

As correctly pointed out by 'Nable80': "%llx" does not create the 0x prefix
for the hex-string. In addition to that: snprintf() adds a terminating \0.

Update ChangeLog

Remove dead / unused code

Again: Compiler happy, we are happy.

Fix typo / editor bug or something like that.

While running code analysis tools this issue popped up. As it is written it is
clearly a NOP, but the reason for why it is written that way remains unknown.
I suspect that it was a textfragment introduced by some repeat-function of the
used editor (think '.' in VIM). The code was introduced by commit a932a7a801
and looked like this in the original form:

   if(!XQueryTree(FbTk::App::instance()->display(), window().window(),
                  &root_return, &parent_return,
                  &children_return, &nchildren_return))
       parent_return=parent_return;//return;

Look at the outcommented return statement. I decided to return from that
function instead of the NOP.

Remove various unused variables

Clang and Gcc-4.9 complaint about some unused variables here
and there. And who are we to not make a compiler happy :)

Update copyright info

Remove unused code / option from FbRun

Use correct buffer size for number2*()

Identify clang compiler

Preparation of release 1.3.6

Fix build issue

Remove reference to src/tests/testSignal

Recreate man-pages

Update release version

Fix build issue with out-of-src-builds

Fix corruption of fbrun-history

This commit fixes issues #72 (brought up + different solution by Mattias
Guns; I received a similar patch by 'Nable 80' via ML and discussed the
issue in #fluxbox with 'Nable 80'), patch #73 (Mattias Guns) and finally
patch #162 (Ulrich Eckhardt; this commit is heavily based upon Ulrich's
work).

The original code was overly complex. It tried to avoid writing
bytes to the disk at the expense of comprehensibility and as a result it
was buggy. I looked at both patches from Mattias and 'Nable 80' which address
the bug with skipping entries in the history-file (my fault: incorrect use
of outfile.ignore(1, '\n')): They provided a proper fix for the problem
but I decided to use Ulrich's code since it improves the whole code by making
it a lot simpler.

So, kudos to all of you.

Fix loading fbrun-history

Previous code add one additional entry on loading the history. This
commit is one part of the patch #162 (see [1] and [2]), written
by Ulrich Eckhardt <doomster@knuut.de>.

[1]: https://sourceforge.net/p/fluxbox/patches/162/
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=fbrun-bug636632.patch;att=1;bug=636632

make use of FbTk-api

treat windows having WM_CLASS == "DockApp" like DockApps

this commit implements feature-request #317: "Add support for GTK dockapps.":

"Back in 2010, WindowMaker implemented a system where windows with WM_CLASS
res_class = DockApp would be treated as if they had initial_state =
WithdrawnState, since GTK refuses to allow this."

Corrections for border width for relative resize

Code cleanup

File name expansion is done internally by the Slit::loadClientList, so there
is no need to duplicate the code.

fix: check the correct XClassHint property

kudos to Arkadiusz Bokowy (this commit is a slightly changed version
of a patch sent to the devel-ml): when retrieving the '.res_name' of
a XClassHint we should check '.res_name' and not '.res_class'.

the other changes only reduce the code.

fix uninitialized variables

fix _NET_MOVERESIZE_WINDOW resize issue (#1108)

handing over the dimensions of a WinClient client must not contain properties
of the FbWinFrame, otherwise they get added twice in
FbWinFrame::moveResizeForClient() and thus result in a resizes when no resize
is wanted.

other changes: it's easier for me to detect the nth bit when the value looks
like (1 << 8) instead of 0x0100 (for the 8th bit). that is why i changed
0x0100, 0x0200 etc. in the nearby code.

allow a timeout of a full 'unit'

the -1 in the FbTk::FbTimer::remainingNext() function was pointless in the
first place anyway: reducing the timeout by just 1 microsecond improves
nothing (in this case). if the timer triggers exactly at a full unit (second)
then it's correct to wait for the full next unit.

cosmetic, less code

detect minute-based strftime-formats (again)

the lag / skipping of the clock was not caused by faulty timer code
on fluxbox's side but by the behavior and inner workings of time().
since this is fixed now (913244789f) we can now rollback ec7fe513c8
and detect strftime-formats which need intervals of seconds or minutes.

minor: the small change to FbTk::Timer::setTimeout() reduces one
start() / stop() cycle for a running timer.

fix clocktool lagging behind and skipping seconds

from time to time (...) time() might be off to gettimeofday() by a
second. the reason for this is that time() is usually implemented
by just returning the field 'second' of the struct that represents
the clock inside the kernel. gettimeofday() on the other hand also
takes the 'fraction' field (mostly 'nanoseconds') into account and
thus is closer to the current time than time().

the result of using time() was a perceived 'lag', sometimes the
clocktool even skipped a second. by using FbTk::FbTime()::system()
instead fixes the issue.

removed reference to 'defaults.hh'

merge Sami Kerola's new build-system

use function fluxbox::findScreen()

fix excessive loading of keys file caused by xmodmap

xmodmap (and other tools) trigger MappingNotify events. a single xmodmap
expression such as "keycode comma = comma semicolon" might trigger 4 or 5
MappingNotify events. loading the keys file on each of them is quite
unefficient.

fluxbox now uses a (250ms) timer which is reset upon further events.

move shared build instructions for nls into a common file

make sure that result of division is signed int

there is problem that x/y ended with unsigned int value due to
width()/height() and negative result of division ended up being big
it causes Focus to move window due to screen boundary checks

fixes annoying behaviour of window moving few pixels with
Mod4 KP_8 :MacroCmd {ResizeTo 100% 50%} {MoveTo 0 0 Top} {Raise} {Focus}

Fix the Bulgarian translation's codeset.

The codeset of the Bulgarian translation was incorrectly specified as
ISO-8859-1 instead of CP1251.  This led to incorrect transcoding to
UTF-8 and the display of wrong characters in the Fluxbox menu.

Fix race condition on shutdown

This commit fixes primarily a race condition that occurs when xinit(1) shuts
down: by not acting properly fluxbox gets caught in an infinite loop. It
caused bug #1100.

xinit(1) sends a SIGHUP signal to all processes. fluxbox tries to shutdown
itself properly by shutting down workspaces and screens. While doing that, the
Xserver might be gone already. Additionally, fluxbox used to restart() itself
on SIGHUP, which is clearly not the right thing to do when xinit(1) is about
to end the session.

So, fluxbox does this:

* handling SIGHUP now shuts down fluxbox without clearing workspaces and
  screens.

* A 2 second alarm() is triggered in Fluxbox::shutdown() as a last resort

* XSetIOErrorHandler() is used to recognize the disconnect from the xserver.

* SIGUSR1 is for restarting fluxbox, SIGUSR2 for reloading the config

* FbTk/SignalHandler.cc/hh is gone; this unused abstraction served currently
  no real purpose. Signal handling is now done in main.cc

* Unrelated to the issue itself src/main.cc was trimmed down quite a bit and
  the code (responsible for handling the command line interface) was moved to
  src/cli*

update of copyright info

Fix ArrangeWindowsStack* for multi-head displays

* Fix integer wrap around for some situations (resulting in a very wide
  window):

      w = max_width - x_offs - (*closest)->widthOffset()

  If the given window is on the right most display and thus 'x_offs' is
  bigger than 'max_width' (half of the display width), the resulting 'w' wraps
  around and becomes very large.

* Place a single window via ArrangeWindowsStack* as well
* Some minor code styling / reordering along the way

Add support for stacked tiling via ArrangeWindows*

Fix lost keypresses after workspace change (#1067)

Do not Ungrab the keyboard for a KeyPress event, this causes us to lose the
KeyRelease event which is needed to ungrab the keyboard after the event
happened.

update hebrew translation

Updated Japanese Translation

Constify the type passed to std::equal_to.

std::bind2nd() has problems with the existing call because it uses the
argument type passed to std::equal_to() in std::binder2nd()'s constructor,
but WinClient* does not have the const specifier that `client' does.

The call works fine with libstdc++ because of the way it implements
std::bind2nd(), but fails with libc++ and possibly with other STL
implementations as well.

fix detection of $HOME folder

usually $HOME is set when fluxbox runs. in some rare scenarios (eg., fuzzying
binaries to detect bugs) one could launch fluxbox by using 'env -i' and thus
eliminating $HOME from the environment. to prevent crashes fluxbox uses now
'getpwuid()' when $HOME is not set to detect the home folder.

cosmetics

Returning EXIT_FAILURE on exit in fluxbox-remote.

Speedup overlong text detection

Detecting very long window titles is done via FbTk::TextUtils::doAlignment().
Instead of removing one char from the title at a time to see if it fits into a
given 'max_width', we now use a binary-search like approach to get faster to
the right value. This massively improves the speed for windows with
(arbitrary) long window titles (see bug #1090, javascript

    document.title = new Array(4999).join(".");

leads to massive waiting for fluxbox to detect that this window has a very
long title).

In addition to that Xft returns 'wrapped' shorts ('integer overflows') for
long texts: XGlpyhInfo.xOff is declared as signed short, it's able to hold
~32k pixels. A monospace font with font-size 10 produces an integer
overflow after 3276 chars / glyphs, thus rendering the check

    if (text_width < max_width) { /* ... */ }

pointless and leading rendering the whole title. By calculating some kind of
upper limit for a pseudo-wide glyph ("WW") and strictly cutting off the input
string at that limit prevents this issue.

Removing a blank line in nls/it_IT/Translation.m that breaks the -help output.

more compact code

Use shared code, minor code simplification

minor

fix initial window placement to allow proper head detection and window placement based on apps file

* a reasonable initial placement is important for later movements to
  different heads and correct head detection (required by apps file)
* it did not work well in case when (0,0) was not near any head

fix head detection for adjacent heads of too different sizes and window placement based on apps file

* if you have e.g a 1920x1200 monitor and a small 800x600 monitor to the
  right of the bigger one and a small window at the right side of the
  big monitor (but still the whole window area at the big monitor) then
  the original head detection would claim the window is on the small
  monitor because (800/2+windowWidth/2 < 1920/2+windowWidth/2) is true
  for small windows; but that is obviously wrong, the window is entirely
  on the big monitor
* these incorrect head detections did lead to incorrect window
  placements as they were required in the apps file

Fix regression in rendering the Window-Motion-Outline

Commit 79fe2fca1de5140f538e68f6981b27cf7f917e7a checks for pending
motion events and drops out of the FluxboxWindow::motionNotifyEvent() function
early if so. When the user does not use the opaque window movement method an
outline will be drawn to the screen. That outline was not cleaned correctly
with commit 79..

minor code simplifications

Workspace switching on the toolbar via the mouse buttons

Trigger ClockTool every second, independent of the format string

It's hard to hit right moment to update the clock correctly: Either we are a
bit too early and the 'old time' is the same as the 'new time' and the clock
looks 'a bit off' or we are too late and the clock is 'a bit off'. This is
especially the case for format strings which do not show the second and thus
are updated only at the full minute (see bug #1082): if fluxbox does not
update the clock 'now' it would do it one minute later and thus the clock
might show the wrong time for roughly 1 minute.

Instead of coming up with something immensely clever we just trigger the
ClockTool every second. If no update of the shown time is needed fluxbox won't
do anything.

Some minor code reordering as byproduct.

Updates copyright date information in some binaries

mpf

Updated Changelog, NEWS, man-pages for 1.3.5

Fix missing LogicCommands

By removing FbTk/LogicCommands.o from LDADD in src/Makefile.am (commit
06655f6) I prevented the linker to pick up FbTk/LogicCommands.o and thus
rendered all logic-commands useless.

Using a small helper object to pull in the dependency fixes this problem
without relying on manually tweaking the build system.

Initialize FbTk::Timer.m_timeout correctly

Updated Changelog, NEWS, man-pages for 1.3.4

Remove unused variables, cosmetics

FbTk::FbTime::mono() yields microseconds since fluxbox started

Cleanup

More subtle brightening of textures

Feature #3602124: 'LHalf' and 'RHalf' buttons to the titlebar

First draft of feature request of #3602124: Having 2 buttons in the titlebar
which allow quick positioning of a Window into the left or right half of the
current monitor.

Fix bug in renderEllipticGradient()

For odd 'widths' and 'heigths' the texture would not be filled completely:
Given a 'width' of 5 we would render only 4 instances of x (-2, 1, 0, 1)
instead of the needed 5. This results in a texture which looks a bit cut off
to the bottom right side.

Minor cosmetics

Fix integer overflow

I forgot this piece in 779618e45d4571bb6a4866aa2e398780f4b4da5d.

Reduces memory footprint

The buffer for some gradients does not have to be width * height big when two
lines are sufficient.

Branchless code for interlacing a texture

Fix integer overflow for bigger textures

Fix regression regarding timers with equal end-time

std::set<Key, Comp> stores Key only if Comp(Key) yields a unique result (My
mistake: I was under the impression Comp is only used for the ordering). This
prevents FbTk::Timers with equal end-times from actually being started.
Escpecially in situation with multiple ClockTools this lead to stopped timers
(see bug #3600694).

Kudos to Adam Majer for enlightening discussions.

Adds 'ClientPatternTest' command

ClientPatterns might be tricky to get right. Instead of fiddling around in
either the keys-file or the apps-file and restarting fluxbox to see if the
changes had any effect / matched the right windows, 'ClientPatternTest' and
the fluxbox-remote should make this easier:

    $> fluxbox-remote "clientpatterntest (title=.*vim*)"

This causes fluxbox to store the list of matched windows in the
_FLUXBOX_ACTION_RESULT property onto the rootwindow. This property might
then be read by:

    $> xprop -root _FLUXBOX_ACTION_RESULT

or

    $> fluxbox-remote result

The format of the list is:

    win_id \t title_of_window \n

win_id is '-1' when fluxbox wasn't able to parse the given ClientPattern.
win_id is '0' when there are no windows matching the given ClientPattern.

Calculates timeouts of ClockTool based upon System Clock

Users expect time switches to happen upon system clock times. Calculating the
timeout for the next refresh of the shown time via the monotonic clock is
wrong: The monotonic clock yields values based upon some arbitrary point in
time which might be off a little bit to the system clock, a 'full' minute of
the monotonic clock might be in the midst of a system clock minute.

Improve calculation of brighter colors

The old code did not brighten up "pure" colors like "red", "green" and "blue"
at all. The new code use a different precomputed LUT which is based upon
simplified vector math, see the comments in FbTk/ColorLUT.cc

Adds 'he_IL' translations (provided by Genghis Khan)

Fix bug: actually invert a given Texture

Stupid typo.

build-sys: clean up .gitignore file

Simplifies and fix bugs in FbTk::Timer

* Calling Timer::setTimeout() from within Timer::start() might lead to ugly
  behavior (as experienced in bugs #3590078, #3600143, etc; see commit
  4d307dcd10af9d817ff5c05fc40ae7487564cb31, fixes the problem partially).

* Stop a timer first, then call the handler (via Timer::fireTimeout()). A
  given handler might call Timer::start() again, which (re)adds the Timer
  to the control list .. the following Timer::stop() would remove it again.

* Use 'm_start' as indicator if timer is running.

* Move the (now quite short) code of ::addTimer / ::removeTimer
  into the Timer::start() and Timer::stop() functions.

Ensure textures have the correct size bevor applying 'bevel'

Optimize inner loop of pixel transfer in TrueColor

Testing bits-per-pixel in the inner loop is suboptimal, especially since
that value does not change. A little helper macro helps to keep the code
readable, also improves the situation for StaticGray and PseudoColor.

Use the same lookup-tables for solid and gradient textures

improved code documentation

Minor optimization of handling the timers

Fix bug: handle the list of Timers not in-place

With commit 541c8c4 we switched from an (manually) ordered list to a
std::set<> to handle the active timers. The code which checks for overdue
timers now traverses and modifies the std::set<> in place. This might
lead to an infinite loop. Examples of such bad behavior are "flickering of
the tooltip" (bug #3590078) or crashes (bug #3600143) or just insanely high
cpu load when autoraising windows or submenus.

We now make a copy of the std::set<> traverse this instead of the original.

Optional removal of SystemTray tool

Added the option to remove the SystemTray tool completely from
fluxbox.

Reduced lagging begind of windows on slower displays

In certain situations a speedy mouse might generate more move-events
than fluxbox can handle: The event queue will fill up faster than the
repositioning of the window is finished. The user will experience a
window which lags behind the mouse cursor, aka the window-dance.

We now check the next event in the queue and postpone the move a little
bit so the queue does not fill up that fast.

refer to the correct autoconf file in nls/translators.txt

fix little autoconf regression

automake: use AM_CPPFLAGS rather than INCLUDES

The INCLUDES macro deprecated in favour of AM_CPPFLAGS.

References: http://www.gnu.org/software/automake/manual/html_node/Program-Variables.html

automake: fix initialization

Reference: http://www.gnu.org/software/automake/manual/automake.html#Public-Macros

do not try to reach $(top_srcdir)/.git directory contents when building a release tar ball

util/fluxbox-generate_menu: default browswer variable can be empty

Noticed when debugging in mac.

utils: remove bashisms

fbsetbg: The random number generation used 'time' shell internal, which
does not exist in all shells.  Allowing 'ps' output to be part of cksum
input will increase entropy and enhance quality of the randomness.

fbsetbg: The second fix is more important.  In posix shell there is no
'==' comparision operator.

fluxbox-generate_menu: There are no quarantees about echo accepting
options, so use 'printf' for more advanced outputing.

fix 'make distcheck' which had out-of-tree build issue

rename configure.in to configure.ac

It seems autoheader version 2.69 does not work with configure.in file,
and AM_CONFIG_HEADER macro.

aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
configure.in:585: warning: macro 'AM_CONFIG_HEADER' not found in library
Executing:  autoheader

autoheader: error: AC_CONFIG_HEADERS not found in configure.in

Compile fix: forgotten parentheses around value

updated ChangeLog and NEWS

replace XKeycodeToKeysym() with XkbKeycodeToKeysym()

The XKeycodeToKeysym() is deprecated.

References: http://comments.gmane.org/gmane.comp.misc.suckless/9403

prepared manpages for new release

updated Changelog

Fix double text rendering if using parentRelative

src/WinButton.{cc,hh}: cosmetic

Make use of window.stuck.pressed.pixmap

Set WM_WINDOW_ROLE for fluxbox windows

Store XClassHint on stack, not in dynamic memory

preparation of fluxbox 1.3.3

Increased verbosity of 'configure'

Minor cleaning of 'class Fluxbox'

Fix build regression: enable XRANDR support by default

The changes made in b178bed60b5bd8b2c9ed0cbc67fd729ff3820589 used the wrong
variable to set the default state of '--enable-randr' in configure.in, that is fixed now. I
also removed '--enable-randr12': If support for the Xrandr-extension is
available at compile time we set HAVE_RANDR; if there is also support for
Xrandr-1.2 (or higher), we also set HAVE_RANDR1_2 automatically.

Other changes:

* cleaned out public interface of 'class Fluxbox'
* added 'RANDR' to output of 'fluxbox -info'

Fixed bug: use expanded style/theme filename

'filename' might contain a '~' which has to be expanded to work for
regular system calls. We expanded 'filename' already but then did not use
it. Fixes bug #3576586.

Updated Changelog

I removed references to file changes as well, 'git log' works pretty well for
people who want to find out more about the history of files.

I also formatted old entries to have a consistent style all over the file.

Simplified 'configure' / build system

* reduced duplicated auto-code
* renamed '--enable-newwmspec' to '--enable-ewmh'
* don't compile 'Slit'-code when '--disable-slit'
* use AS_IF() in configure.in
* use AS_HELP_STRING() instead of obsolete AC_HELP_STRING in configure.in
* removed redundant calls to 'imlib2-config' to fill in $IMLIB2_CFLAGS
  and $IMLIB2_LIBS, AC_PATH_GENERIC() does that out of the box already

removed empty file

Fixed lost focus glitch on multihead-ws-warping

Added option for focus revert to stay on current head

Rewrite of FbTk::TextureRender

* much more readable and easier to read code
* smaller code
* reduced binary size due to removed big lookup-table for square root
* simple 'optimizations (lookup tables, packing of data), nothing too fancy

Added 'OnTab' highlighting in vim

Added documentation for 'OnTab'

Adds the OnTab keyword for the keys file

Adding the following lines to the keys file restore the old behaviour to
use Mouse2 on tabs to start tabbing, and keep OnTitlebar Mouse2 to lower
the window.

OnTab Mouse2 :StartTabbing
OnTab Move1 :StartMoving

Note: Internal tabs are triggering both OnTab and OnTitlebar events.

minor cosmetic

Add support for nearest corner or edge resizing

Improved vertical alignment of text in FbTk::TextButton

The old formula for vertical align text inside FbTk::TextButton ('height/2 +
font_ascent/2 - 1') produced not always good looking results, escpecially
when different fonts are involved (eg, ClockTool and WorkspaceName have
different fonts and font-sizes).

'(height - font_ascent) / 2 - 1' produces better results.

Additional changes:

* added ASCII-Art to document the involved entities when calculating the
  baseline
* rewritten tests/testFont.cc to accept multiples texts and multiple
  fonts
* removed some internal parts of FbTk::Font from the public interface

removed duplicate function signature for FbTk::StringUtil::extractNumber()

minor cosmetic

Fix regression: switch back to microseconds for DelayCmd

Fix bug: (re)setting timeouts on a running FbTk::Timer might lead to broken timer list

Setting a new timeout on a running FbTk::Timer must remove it from the timerlist,
otherwise the list is not ordered correctly anymore. So, we stop the running
FbTk::Timer, set the new timeout and restart it.

changed timing functions to use a monotonic increasing clock

gettimeofday() is subject to be changed on daylight-saving or to ntp-related
(think leap-seconds). even worse, it is subject to be changed BACK in time. this
is hard to fix correctly (see commit 45726d3016e and bug #3560509). it is
irrelevant for timers to know the nano-seconds since the epoch anyways.

fix sanity check for transient and explicitly placed windows

When a screen has more heads and some part of the screen is not on any
head and some window is placed into this invisible area then the window
is invisible which sucks. This patch repositions such windows so that
they are visible.
Example:
* head 1 is at (0,120) (size 640x480)
* head 2 is at (480,0) (size 800x600)
* whole screen virtual size is 1440x600
* that means rectangle from (0,0) to (640,120) is not visible on any head
  and any windows placed there would not be visible; for example wireshark
  likes to place dialog boxes at (0,0)

Add menu.hilite.font and menu.hilite.justify style resources

FbTk/ThemeItems.cc: move loading additional font resources to load()

The same logic had been already implemented for texture resources.

FbTk/ThemeItems.cc: don't use style resources in ThemeItem<Font>::setDefaultValue()

merge

rephrased documentation about font effects

removed 'always-true' expression

use the 'z' modifier for printing 'size_t' like variables

Bugfix: Don't draw the interlace lines 1px too far

Allow percentage values for some Window commands

FocusableList.cc,.hh: Pass string arguments by const reference.

Found by cppcheck

FbTk/XrmDatabaseHelper.hh: operator== can be const.

Found with cppcheck.

Check .empty() instead of .size() == 0

Found with cppcheck.

Pre-increment non-primitive types.

Found with cppcheck:
"Prefix ++/-- operators should be preferred for non-primitive
types. Pre-increment/decrement can be more efficient than
post-increment/decrement. Post-increment/decrement usually
involves keeping a copy of the previous value around and adds
a little extra code."

Exceptions should be caught by reference.

Found using cppcheck.

Add mwm _MOTIF_WM_INFO atom to advertise mwm hints capability

Applications like urxvt look for the _MOTIF_WM_INFO atom in order
 to know if the window manager implements mwm hints. If this atom
 is not found, then urxvt sets override_redirect when started with
 the borderless option and falls out of the control of Fluxbox.

No need to check if a pointer is null before de-allocating it.

  5.3.5/2 of the C++ standard:

  "In either alternative, if the value of the operand of delete is the null
   pointer the operation has no effect."

changed encoding of nls/it_IT/Translation.m to latin1

moved meta-information around a little bit

README: Add information on cross-compiling for Windows

src/Makefile.am,FbTk/StringUtil.cc: Search relative to the executable.

On Windows, prepend /DUMMYPREFIX to default paths, and replace it at
runtime with the prefix relative to the exe directory.

FbTk/StringUtil.cc: Don't return mid-routine.

Prep for Windows dummy prefix code.

main.cc,FbTk/StringUtil.cc: On windows, use USERPROFILE instead of HOME

util/Makefile.am,fluxbox-generate_menu.in: use EXEEXT

Needed to allow mingw-cross-env cross build

fluxbox-update_configs.cc: Fix on windows - no kill or sigusr2

FbRun.cc: Fix on windows where there is no fork

FbTk/FbString.cc,Font.cc: Windows doesn't have nl_langinfo

FbCommands.cc: Implement ExecuteCmd for Windows

configure.in: Windows requires a library to link for catgets

main.cc: Add a wrapper for two-argument mkdir on Windows

fluxbox.cc: ifdef the signals windows doesn't have.

FbTk/Timer.cc: Check HAVE_SYS_SELECT_H, add alternate for windows

Merge branches 'fix-out-of-range-memory', 'obey-configure' and 'other-improvements' into windows-mingw

FbTk/StringUtil.cc: Fix out-of-range memory access.

if pos is not npos, it will always be less than filename.size().
However, the access later is only safe if there is a character
after pos, which would require pos + 1 to be less than filename.size.

Prepare 1.3.2 release

Proofreading nls/it_IT/Translation.m and added_myself to translators.txt

bugfix: use the imlib cache for every imlib context used

calling imlib_set_cache_size() before a context is created by fluxbox creates
an 'unknown' context. that one is never freed at shutdown.

clean up imlib2 loaders at shutdown

clean up resources on shutdown

updated ChangeLog

small code simplification

Bugfix: clean up static resources correctly

93924af160ea303c94a2576b0e57a04e94c9228c might corrupt memory with gcc-4.6.1 when
finishing fluxbox (clicking 'exit', sending it a SIGINT). Allthough the order, in which static / global
objects are initialized is undefined (at least between separate compilation units), the order in
which they are destroyed is well defined: in reverse order of initialization.

this means, that if 'ScreenImlibContextContainer contexts' (of ImageImlib2.cc)
gets initialized AFTER 'ImageImlib2 imlib2_loader' of Image.cc, it gets destroyed before
imlib2_loader. When that happens, ~ImageImlib2() works on a destroyed object.

(That lead to '* glibc detected * fluxbox: corrupted double-linked list: 0x0000000000dd2710 ***'
later on in 'iconv_close')

refactored MenuCreator

make public only what needs to be public

cosmetics

bugfix: fbsetroot needs to use 24bit visuals as well

12f44680dfefde602f3387c6d385f4c5e68990e4 introduced ARGB visuals. if fluxbox
creates 32bit visuals for the container window or the root window: does not work.

Added support for ARGB visual, patch #3284774

fluxbox now properly displays windows that require ARGB visuals when
an external compositor is running. This was done by creating the
container window with the correct visual and colormap when needed.

Closes #2874629

fixed typo in startfluxbox manpage

updated ChangeLog

removed obsolete handler for the gnome-window manager hints

nowadays every app should use the extended window manager hints exclusively.

updated ChangeLog

ignore .build* directories

updated it_IT translations

cleaned up master translation file

Mark unused entries with '_OBSOLETE' to help other translators remove
unused entries from 'their' language.

Removed some pure technical translations meant for (copy and paste) error reporting
to developers or to the irc channel anyway. Since english is the common denominator
in bug reporting anyway, having the translated message to retranslate again is pointless.

Fix compilation with intel's compiler

the deleted function was never used, otherwise it would generate an error with other compilers as
well. icc noticed that it was nonsensical even when it wasn't used and complained.

Documentation: fix default values of a couple more resources

Documentation fix: default value of slit.placement resource was wrong

Documentation mentions nonexisting resource: session.numLayers

so I removed the obsolete line.

Make sure FocusableList disconnects from signals when it is destroyed

Enable connecting to const Signals

The idea is that connecting to a signal doesn't change it's state or the state of the object
owning the signal (even though it needs to add the functor to the list for later reference).
Emitting, on the other hand, is usually done as a result of a state change and therefore remains
non-const.

Additional benefit of this arrangement is that objects can export const references to signals to
allow connecting, while keeping the ability to emit to themselves.

Fix VPATH builds with --enable-nls

I needed to add explicit $(srcdir) in Makefiles when referencing to Translation.m.
I also removed generated-*.m files from the tree since they can be easily regenerated (and they
were confusing VPATH logic). They can be added to the distribution tarball later if needed (but
hopefully everyone has iconv).

Add explicit ReturnType cast to operator() of FbTk::Slots

without this it wasn't possible to construct a Slot returning void from functors returning some
real value because the compiler would complain about "return statement with a value in a function
returning void".

Theoretically, this may produce some unexpected type conversions, because static_cast is slightly
stronger than implicit cast, but I judge the risk to be negligable (the alternative would be to
provide explicit specializations for slots returning void - too much typing)

Upgrade FbTk::Timer so it can take an arbitrary functor as a parameter

Rename Signal::connect function taking an already-constructed slot to connectSlot

I do this to avoid compiler ambiguity between the two versions of connect()

Add comparison operators to FbTk::RefCount

without them, gcc would compare them by converting them to bool first, which is not exactly what
one would expect. Frankly, I'm surprised it even worked without this.

Use RefCount to store keybindings

I'm doing this because I want to have access to keybindings from lua and for that I need more
flexible ownership semantics.

Remove the assignment operator from a regular pointer to a RefCount

it is too easy too shoot yourself in the foot with it, other smart pointers also don't allow such
assignments. If you do want to assign to a RefCount pointer, use reset().
ps: assignment between two RefCounts remains possible, of course.

Remove obsolete code

ps: it was already commented out, I'm just deleting it

add FbTk::makeRef function, for easier construction of RefCount pointers

FbTk::Timer accepts Slots instead of Commands as the former are more general

Signal::connect now also accepts an already-constructed Slot

This way we can use Commands as signal handlers out-of-the-box.

Make FbTk::Command inherit from FbTk::Slot

Command offers a subset of functionality and could be completely removed at some point.

Fix a small bug in BScreen constructor

it was testing for FbWindow.property() == Success, where it should've tested for == true.

Add a reset() function to FbTk::RefCount

to make it's interface more compatible with other smart pointers.

Mark FbTk::StringConvertor as NotCopyable

Prepare the Slot classes to be used independently of Signals

Added some polish around them and, to mark this special occasion, moved them out of the SigImpl
namespace.

PS: This partially reverts commit 0775350fee345e37fb59835dda4d85664346b606, since I had to
reintroduce ReturnType template parameter, because it will be used in other places. But Signal classes
remain without the ReturnType, because I still cannot imagine how would it be used.

Add template copy constructor to FbTk::Refcount

and remove a an "almost" copy constructor (almost, because it takes a non-const reference
parameter) which was useless.

FbString: fix build without iconv

Commit 690d926 (introduced FbTk::BidiString) broke building without
HAVE_ICONV, because of wrong variable name and use of iconv_t type.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

sync the copied config files to disk before continuing

otherwise a race condition might appear between copying the default
config files to .fluxbox/ and executing 'fluxbox-update_configs'. under
macosx this lead to 'fluxbox hangs'.

Rebuilding the fluxbox docs to change fix a small grammer mistake

 Fluxbox's man page had "allows to", which should actually be something like
 "allows one to".

 The rest of the .ins were rebuilt as a result. No changes otherwise.

Re-licensing the ostrich theme due to issues regarding it's distribution

 CC-BY-NC 3.0 is a great license, but it limits how well we can redistribute
 the theme it's self. This change allows distros (such as Debian) to keep this
 theme in the source.

bugfix: do not change workspaces when using NextWindow / PrevWindow buttons in toolbar

regrab ButtonMotionMask as well (needed for 'Move' events in keysfile)

bugfix: remap keysyms to keycodes after 'MappingNotify', fix #3386257

setxkbmap and xmodmap both might change the keycodes. thus fluxbox needs
to remap the keysyms from the currently loaded keytree to new keycodes
after it received a 'MappingNotify' event.

we do not reload() the keys file because:

* the user might work on it right now
* remap only needed symbols is cheaper than parsing the keysfile anyway

Updated styles 'bloe' and 'arch' to look better without xpm-support

Use _NET_WM_ICON from 32bit apps (xfce4-terminal) correctly

The icons coming from _NET_WM_ICON are argb32. fluxbox uses such icons
in entities such as 'clientmenu', 'iconbar', 'titlebar'. These entities
are not related to the depth of the winclient but to fluxbox's default
depth. Using 'winclient.depth()' is a mistake, since fluxbox is unable
to copy pixmaps from 32bit to 24/16/15bit.

It is not necessary either, because fluxbox should extract the argb32 icon
data directly into the pixmap with the correct depth in the first place.

This fixes (reopened) bug #1852693.

Note: The whole icon code in fluxbox is quite messy, lots of copying and
scaling. It might be simpler and fater to just extract the icon when needed
, in just the size that is needed.

TextDialog now handles parentrelative labels

Prior to this patch, TextDialog did not handle parentrelative labels;
borrowing code from OSDWindow, now TextDialog properly handles this.

Eventually, I plan to combine the good parts of TextDialog and OSDWindow
into OSDWindow, and then let TextDialog derive from OSDWindow... but for
now, here's the band-aid fix for the issue without the refactorization.

TextDialog and ToolTipWindow style rendering bugs fixed

TextDialog windows (such as 'set title', or 'edit clock format') now
properly render their titlebar to match the current style.  Previously,
the titlebar font settings were controlled by window.font.*, and this
became apparent because window.font.effect needed to be set to put
'halo' on the titlebar of these TextDialogs.  However,
window.font.effect controls the effect on the text within the editbox on
these as well, having these set in the same location is far from
desirable.  Specifically because the TextDialog essentially emulates the
titlebar of other windows.  So, after this change, window.font.effect
still controls the text in the editbox, but the titlebar area is themed
as the titlebars of other windows.

Text justification of titlebar and border width, is now respected in
TextDialog.  Also, previously the edit box was sized in an odd way; one
which left part of the window actually undrawn (so you'd get artifacts
from whatever happened to be on the screen in that position when it
opened); this has been addressed.

TextDialogs, rather than going to the center of the entire desktop, now
center on the _current head_, which prevents the awful positioning where
half of the window is on one screen and half is on another.

Lastly, when hovering your mouse over the iconbar button for a window
with a title that's too wide to fit on the button, a tooltip is
displayed.  This tooltip themes itself to match the button, however it
wasn't using the theme properly (similarly to how TextDialog was)... and
as such, also wasn't using the proper font effects.  This has been
addressed just as it was for the TextDialog.

Make SignalTracker always disconnect itself from Signals

previously, the tracker disconnected itself only when the caller passed withTracker = true to the
leave() function. However, the default value was for the parameter was false.

Non disconnecting from signal when stopping tracking creates very dangerous situation because the
signal still holds a pointer to the tracker. This resulted in a segfault when exiting fluxbox,
because the tracker (FluxboxWindow) got destroyed before the signal (BScreen::focusedWindowSig),
and the signal was using an invalid pointer when it tried to disconnect itself from the tracker.

Instead of setting withTracker to true by default or changing all invocations of leave(), I
decided to make the tracker disconnect itself unconditionally because I could not find a use case
for the opposite behaviour.

PS: This message is in fact longer than the actual commit.

Remove all trace of Observers and Subjects

this marks the completion of the transition to FbTk::Signal

Convert ToolbarItem::resizeSig to FbTk::Signal

Convert Screen::reconfigureSig to FbTk::Signal

Convert Focusable::attentionSig to FbTk::Signal

Convert FbWinFrame::frameExtentSig to FbTk::Signal

Also, I spotted a potential bug in the code. I marked the place with XXX. Someone should take a
look at that.

Convert FluxboxWindow::hintSig to FbTk::Signal

Convert FluxboxWindow::layerSig to FbTk::Signal

Convert FluxboxWindow::stateSig to FbTk::Signal

Remove Observers from testSignal.cc

Convert FluxboxWindow::workspaceSig to FbTk::Signal

Convert Focusable::orderSig,addSig,removeSig,resetSig to FbTk::Signal

Added FbTk::MemFunBind - a functor which binds all arguments of a function

Make FbTk::MemFun[12] inherit from std::unary/binary_function

this way, they can be used as inputs to std::bind1st and friends

Make FbTk::MemFun[0-3] use their ResultType parameter

previously they declared the parameter, but ignored the return value of the member function. I've
changed it so they pass the return value, if it is not void. MemFunSelectArg didn't have the
ReturnType template parameter, so I added it for consistency. Since I was already editing the, I
made all the operator()s const.

Convert Focusable::dieSig to FbTk::Signal

Last round of simplification of Signal/Slot classes

- merged all the common stuff from 0,1,2,3 argument versions into one common base class
- removed ReturnType template parameter as it was instantiated with "void" everywhere and the
  current ignores the return value of the callbacks anyway

Don't crash when a slot is deregistered in the middle of signal processing

this was possible (and used) with FbTk::Subject, but the implemetation of FbTk::Signal didn't
support it, which made it impossible to continue with conversion.

Simplify Slot.hh

Replace CallbackHolder, FunctorHolder and SlotHolder with a (smaller) set of polymorphic classes.
SignalHolder now stores a (smart) pointer to the class.

Make RefCount<> more sensible

the previous version of operator*() made no sense. E.g., it violated the invariant
(*ptr).foo <=> ptr->foo. The dereferencing operator now returns a reference to the pointed-to
object, rather than a pointer to it.

I also added a bool conversion operator, which can be used in testing the NULL-ness of the
pointer. Anyone wondering if that could be done in a simpler way is encouraged to read
<http://www.artima.com/cppsource/safebool.html>.

And, finally, I removed the mutable flag from the m_data member, since it does not need it.

Remove the Observer dependency from FbTk::Menu

Convert FbTk::Theme::reconfigSig and friends to the new Signal system

I removed the const versions of reconfigSig() in the process since FbTk::Signal has no const
methods anyway.

Simplify FbTk::Signal template classes a bit

basically, i just got rid of Signal[0-3] classes and moved their contents to the appropriate
specialization of FbTk::Signal

also, this fixes the
no matching function for call to 'MemFunIgnoreArgs(FbTk::Signal<void, FbTk::SigImpl::EmptyArg,
FbTk::SigImpl::EmptyArg, FbTk::SigImpl::EmptyArg>&, void (FbTk::SigImpl::Signal0<void>::*)())'
error i had in the following commit.

Fix make install failure with some autotools versions

apparently, some versions of autotools don't know about $(builddir) variable. I replaced it with
".".

Can check CARDINAL properties in CLIENT PATTERNS

Introduces a new member function, FbWindow::cardinalProperty()

This change also changes other code that previously used
FbWindow::property() to do the same thing as the new function; this
reduces code duplication.

There are still some bits of code (Ewmh.cc, extractNetWmIcon()) that use
FbWindow::property() to retrieve XA_CARDINAL values, but as the new
method is designed for getting a _single_ property, and that code uses
FbWindow::property() to retrieve the number of values present, and then
grab all of them; it's a different use case.  I opted to not try to make
cardinalProperty() into some monolithic all-purpose cardinal method;
FbWindow::property() works just fine for that.

This change also adds an optional (default=NULL) boolean to
FbWindow::textProperty and friends that allows the caller to determine
whether or not a value was actually retrieved.  This was necessary for
integrating FbWindow::cardinalProperty with the codebase, and it seemed
to fit with FbWindow::textProperty as well.  Prior to this change, if
you got a return value of "", you wouldn't know if you successfully
retrieved the value which happened to be blank, or if you failed to
retrieve the value.  Now, you can pass the address of a boolean if you
so choose in order to differentiate these situations; the same applies
to the new FbWindow::cardinalProperty().

fluxbox-remote now properly returns exit status

The previous check relied upon the (undocumented) return value of
XChangeProperty to determine the exit status; at least, on my gentoo system,
the function seems to return 1 even when it fails to change the property
due to contrived, and invalid, parameters.  However, setting an error
handler allows proper detection of this case.  So, now the return status
properly indicates whether or not the property was changed (but not
whether fluxbox liked the command!).

Include src/tests in the distribution tarball

and add a configure option for building them (default: off).
This patch fixes an error when configuring the tarball, where configure complained it cannot find
src/tests/Makefile.in.

Fix "comparison between signed and unsigned" warning

Add backup and vim swap files to .gitignore

Woops, forgot to add the file.

Make sure `make distcheck' is successful

- added rmdir commands to uninstall rules of all Makefiles under data/styles
- added \n at the end of files which had none

bugfix: do not warp workspaces with only one workspace

Fix VPATH builds

Fix a couple of "comparison between signed and unsigned" warnings

fixed typo in 'MerleyKay' style, closes #3286430

bugfix: use 'unsigned long' to feed XChangeProperty, closes #3285968

old code crashed on sparc64, pid_t seems to be 32bit on that platform.

Changed fbsetbg's tips to the new behaviour.

Fix a pair of warnings reported by clang

Menu.cc: send debug output to cerr, make the output more sensible

bugfix: return 'height' if container is rotated vertically, closes #3195728

iconbar.iconWidth property was ignored due this bug.

Fix assorted typos in manpages

make XMESSAGE a variable and use it consistently

Previously, gxmessage was getting substituted in one place and not
another.

avoid trailing spaces between app and closing }

Add a few lines of code to prevent a few spaces in some menu output.
'{$app $options}' would expand to '{app }' if no options were set.

Also, while scattered throughout, in this particular spot the
unnecessary braces around some of the variables (and not around some
others) and inside flux's braces could be very visually confusing and
lead to editing errors, so removed those.

separate functions and main code

Transpose one function from main to the rest of the functions and one
block from the top of the script to the top of main. Add an 'End
functions' comment.

add the configuration file equivalent of '-in'

silence cmp

cmp's '-s' flag is POSIX - if it's as portable as that's supposed to
mean, that might be used instead.

updated turkish translations

compile fix: added <cstdlib> to provide declaration for 'size_t' (gcc-4.6.x likes it that way)

compile fix: arguments must match declaration

Sun CC++ 5.11 complaint on linking about missing symbols 'nextWorkspace()',
'prevWorkspace()' etc.

removed useless code

configure fix: sstream test needs math.h, thus we should test math.h before

bubbled up on solaris10, had to install 'math-header'.

cosmetics

compile fix: sunCC again, wants a compile time constant for arrays

compile fix: sunCC 5.11 (sunstudio 12) compiles and links again

biggest change: renaming of 'class Layer' to 'class ResourceLayer' in
Layer.hh to handle complaints about 'ambiguous Layer: Layer or FbTk::Layer'.
'ResourceLayer' sounds crappy, but that was the best I could come
up with right now.

merge

code cleanup: moved code from public API to implementation

renamed 'Region' to 'Area' to avoid conflicts with 'Region' from Xlib.

bugfix: reposition windows only if they are invisible

changing the layout or the number of the attached monitors
might lead to invisible windows. only those windows should be
positioned to the closest monitor, if they are not visible
already.

code deduplication: use RectangleUtil::insideBorder()

prepare BScreen::XineramaHeadInfo to be 'RectangleLike'

added RectangleUtil::overlapRectangles() + test cases

updated date of manpages

added tests/testRectangleUtil.cc

fix some escaping problems in the man pages

some love to src/tests, use automake to use the same build environment as the rest of fluxbox

compile fix for clang, forward declaration of FocusControl was not enough

compiler cosmetic: changed return type of ScreenPlacement::placeAndShowMenu() to void, closes #3204402

bugfix: do not use anything from the current ClientMenuItem after m_client.focus(), closes #3210493

m_client.focus() might call ~ClientMenuItem(), thus m_client is not available anymore. the crash was triggered by trying to deiconify a client via the clientmenu. this triggers a signal to remove and destroy the current ClientMenuItem.

fix misordered Toolbar::Placement strings, closes 3195721

remove doc/ru reference in configure.in

Removed Russian translation of fluxbox(1).

Translation is out of date and may puzzles users.

Removed ONLINE DOCUMENTATION section from man pages.

Because link in this section not available now.

updated NEWS for 1.3.1, increased version number

updated ChangeLog

created manpages

cosmetics

bugfix: submenus didn't hide if a delay was set

use the FbTk::Timer API correctly, bug(s) introduced by

   1f0adef4daa2da5b08ed7f41e7a0ce1e3f71e46f
   e68511794130388ab9668fdef0dcf48dbbf002fd

cache result of getWorkspace()

better solution for warping transient windows

see #3088856 / 09f99a4674a75a201effdc912d79a28c2dad4225.

at the moment this fix looks side-effect free, time will tell.

intermediate fix for segfault when warping transient windows to different workspace, see #3088856

warping a transient window to the next workspace creates a cycle between
BScreen::changeWorkspaceID(), BScreen::reassociateWindow(), Workspace::removeWindow(),
FocusControl::unfocusWindow(), FluxboxWindow::setCurrentClient(), FluxboxWindow::focus()
and so on.

for now we just stop allowing transient windows to be warped, it is most
likely a bad idea anyway having the modal dialog on one workspace and the
(dead) main window on another one.

this issue must be analyzed further, since there might be a deeper problem
with the way the focus code works.

fix calculating the width / height of SystemTray (closes #3150939)

SystemTray tool should use the right fallback resource

updated ChangeLog

removed unused headers

moved Menu placement into ScreenPlacement::placeAndShowMenu()

little helper function 'isTitleVisible()' for FbTk::Menu

code deduplication

bugfix: place WindowMenu correctly upon first call (closes #2731524)

FbTk::Menu::updateMenu() recalculates the width() and height() of the
window. this must be done before the menu is moved to fit completely
onto the screen.

the 'menu().raise()' command is not needed, that is done inside
'menu().show()' already.

renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem

disabled overhead base classes 'FbTk::Layer' and 'FbTk::LayerItem'

had to add <algorithm> at various other files as a result of this change.

irrelevant 'virtual' destructor

code deduplication

updated year and copyright info

almost 10 years of fluxbox

merged crash fix

moved rarely used 'cpccpc' out of class declaration

don't use hardcoded references to positions in the menu

bugfix: consistent use of 'int' for alpha values (#3187373)

WindowMenuAccessor returned strange alpha values if compiled
with 'g++ -Os'; unholy black magic happens if template<int> faces
functions returning only 'usigned char'.

bugfix: render 'sunken' gradients correctly

use FbTk::StringUtil API

renamed Texture:DEFAULT_BEVEL to Texture::DEFAULT_LEVEL

cosmetics

Bugfix: don't render textures with dimension of 0

At least 'invertRGB()' does not like 'width' or 'height' being 0.
341b2f43e511e39dd was triggered by this problem as well.

Render rectangles instead of squares to test TextureRender.cc

cosmetic fix in fluxbox-keys

fbsetbg: improved aspect-ratio-filling for feh (thanks Jeremiah Mahler <jmmahler at gmail com>

Closes http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=583704

Fix bug: 'src_image' might be NULL if width||height are 0 (#3188223)

With ROT90-SystemTray fluxbox crashed. It is a bit unclear of where
to catch pixmaps / windows with either width or height equal to 0; IMHO
this needs more investigation.

fix grammar

Merge branch 'master' of ssh://git.fluxbox.org/fluxbox

Fixed a possible crash when using a slot m_holder = 0

1.3.0 version for configure

readded default style path to init.in

updated documentation

Updated NEWS

Added 3rd to extra dist

updated pt_BR translations, closes #2940952

added documentation about the 'screen' client-pattern

merge ChangeLog

updated ChangeLog

allow to override 'FocusNewWindow' via .fluxbox/apps

bug fix: semantic differences between WinState::Decoration and Remember::save()

build fix: revert e38994ae727a3bc7fa77f45d5bdbb97dffcbd1e5

'xft-config' is deprecated (http://lists.freedesktop.org/archives/xorg-devel/2010-March/006750.html)
and does not exist anymore on 'bleeding edge' versions (gentoo). 'pkg-config'
is the new way of doing things. 'pkg-config --libs xft' does only report
the libs needed and the linker finds out other dependencies on its own. currently,
'pkg-config' (version 0.25) reports only '-lXft'.

if the user wants for example LDFLAGS="-fuse-ld=gold --no-add-needed" then
all the needed libs must be produced, otherwise linkage fails. at the moment
it seems that fluxbox calls 'XftMatrixRotate()' and 'XftPatternAddMatrix()'
which both seems to trigger the need for 'fontconfig':

   undefined reference to 'FcMatrixRotate'
   undefined reference to 'FcPatternAddMatrix'

is 'pkg-config --libs xft' reporting to few libs? in comparison to
'xft-config --libs' for sure. bug? feature? i am not sure. there are
several ways to address this issue:

* append the needed libs manually via LIBS or LDFLAGS

  env LIBS="-lfontconfig" ./configure

* change build-system of fluxbox to do something like

   pkg-config --print-requires-private 'xft' 2> /dev/null || echo xft)`

(pkg-config version < 0.2x does not have --print-requires-private, which
 then leads to not print out all libs needed, which would then require
 a fallback to xft-config since an older system anyways, evidence is
 old pkg-config)

* changing build-system of fluxbox to use something like:

  pkg-config --static --libs xft

(which reports really all libs, even more than actually needed, check out
  http://osdir.com/ml/debian-bugs-closed/2011-01/msg01112.html)

* fix 'pkg-config' (or the related xft.pc) to report '-lXft -lfontconfig'
(not our code, but preferable)

* use 'pkg-config --libs xft fontconfig' since we know that calling the
xft functions requires linking against 'fontconfig' as well:

  pkg-config --libs xft fontconfig

which is what we use to get rid of the build-errors

fix missing ')' introduced by e38994ae, the rest is cosmetical

updated 3rd/vim/fluxkeys.vim

added little helper to create vimballs

added 'ArrangeWindowsHorizontal' 'ArrangeWindowsVertical' to 3rd/vim/syntax/fluxkeys.vim

updated the AUTHOR file

added 3rd/ party stuff, vim related files for now

build fix: use 'xft-config' instead of 'pkg-config' to use the right libs

when linking with binutils-gold and --no-add-needed it is not enough to
just use -lXft but it must be -lXft -fontconfig (and some more). since we
use 'pkg-config --libs' to find out about the needed flags and 'pkg-config'
only returns -lXft (except by using

   pkg-config --libs `pkg-config --print-requires-private xft`

) we switched to 'xft-config --libs' which gives us the complete list of
all needed libs.

the issue was brought to attention by

   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=554386

but the proposed fix was just quick and dirty.

bug fix: make fluxbox work under nxserver, closes #2813828

nxserver-3.x creates a XExposeEvent for the unmapped FbTk::Menu(), which is
not configured completely yet (hence unmapped). this causes a call to
FbTk::Menu::clearItem() which then uses a value of 0 for m_rows_per_column
to divide the current index which triggers a SIGFPE.

it is still unclear, why nxserver-3.x creates the XExposeEvent for the
unmapped (menu) window. doing nothing if the menu is unmapped 'fixes'
the problem for now.

many thanks to Lars Engels (bsd-geek.de) to assist me in debugging this
issue.

compile fix, new name of setMinimumSublevels() is setMinimumColumns()

removed useless include statements

'typeinfo' was needed for RTTI in isItemSelectable() (see last commit)
'algorithm' is already included some lines above

better use of API, no need for 'timeval' in Menu

MenuItem::isEnabled() is sufficient to decide Menu::isItemSelectable()

MenuSeparator is never enabled since it returns always 'false' in its
implementation of isEnabled(). no need to use RTTI imho.

small refactoring of FbTk/Menu code

* removed useless struct _menu
* code deduplication via renderMenuPixmap()
* improved documentation:
   - 'sublevel' actually means 'column'
   - 'persub' means 'row_per_column'

compile fix: missing symbol (SystemTray::getNetSystemTray()) when configured --disable-toolbar

updated Changelog

bugfix: do not assume ':number.screen' as the result of 'DisplayString()'

a newer xlib recently changed the result of 'DisplayString()' a little bit:
instead of returning ':0.0' or ':1.0' it yields ':0' or ':1'. our code to
transform this string into something that includes the currently used
Screen worked only on something like ':0.0'.

we now find the '.' after the ':' and strip that part away.

bugfix: std::string() does not like NULL on construction

not having DISPLAY set (eg: on a headless system) caused fluxbox to crash.

use 'system()' to run 'fluxbox-update_configs'

by using FbCommands::ExecureCmd() we run 'fluxbox-update_configs' in
the bacground while booting a new fluxbox instance already. 'system()'
waits until 'fluxbox-update_configs' is done and then gives the control
back to fluxbox.

updated 'texturetest.cc' to work with current API

bugfix: ' floating point exception' due wrongly placed code

while integrating the old 'getSqrt()' function into the 'bsqrt()'
function i misplaced some code. this lead to 'r' being 0 on the
first run. doh.

upgrade default 'init' file to reflect current configVersion

updated ChangeLog

merged conflicts

pushed to early ...

changed the way we create the '~/.fluxbox' directory to avoid race conditions

before bringing up the first instance of Fluxbox we prepare the directory
and the files it needs. if the config version of exiting files is lower
than what we expect, we upgrade the config files. after that we bring
up Fluxbox.

the old way was problematic because setupConfigFiles() calls
'fluxbox-update_configs' which does its job in the background while
fluxbox continues to boot. 'fluxbox-update_configs' sends a USR2 signal
to the booting fluxbox (it might even be finished, no one knows) which
triggers 'load_rc()' which triggered 'setupConfigFiles()' again which
might trigger 'fluxbox-update_configs' again (on my machine
'fluxbox-update_configs' was called 3 times and left a pretty crippled
'keys' file when it was done).

bootstrapping before bringing up fluxbox resolves the issue. as a bonus:
no need to send USR2 to fluxbox to reload the config file because fluxbox
has not even tried to read it yet.

cosmetic

recovered lost change from 041d586972db4da170123f5468d7b11d4eda8ae5

got lost in d3eabeb805fdbd162c0743ed86a67e014e37c097 somehow

bugfix: avoid naive use of 'putenv' by providing 'FbTk::App::setenv()'

to quote from 'man putenv':

   The string pointed to by string becomes part of the environment,
   so altering the string changes the environment.

so, using putenv like

   {
      std::string foo("FOO=bar");
      putenv(foo.c_str());
   }

is wrong and leads to a potentially corrupted environment. valgrind
complaint correctly.

FbTk::App seems to be the appropriate place to hold '::seten()'
because it alters the environment of the application.

missing initializations

'valgrind' reported a lot of code branches based upon uninitialized
variables. some are not identified yet.

request explicitly as many elements for the gradient tables as we need

the next step is to not use 'unsigned int' and then only store 'chars'
in it, maybe even using RGBA data instead of separated arrays for
r, g and b.

bugfix: forgot to resize 'pixels' before putting values into it (facepalm)

added 'ArrangeWindowsVertical' to actions

moved commandline parsing to its own function

lots of code cleanup, reordering, trimming public API, bugfixes

## FbTk/ImageControl.hh:

* moved 'getSqrt()' over to TextureRender.cc because it is used only there
* removed unused members m_root_window
* use std::vector<> for colors and for the gradient buffers.

## FbTk/ImageControl.cc:

* fixed memory leak in '~ImageControl', 'pixels' where not deleted[]
  at all. switched to std::vector, non-issue anymore.
* moved identical code into functions 'allocateUnallocatedColors', 'initColortables'

## FbTk/TextureRenderer:

* removed 'from', 'to', 'interlaced' from class, only used in
  'renderGradient()' and are actually part of the given
  texture.
* removed 'xtable', 'ytable' from class, only used in
  'renderGradient()'
* removed 'colors' from the class, is part of 'control'
* moved render actions (invert, bevel1, bevel2, *gradient), they need more
  love but for now this is sufficient

use FbTk::API to reduce code duplication

code simplification by reducing if-else hell

a lot of the parsing-related and menu-building stuff is just plain
stupid boiler plate code. putting the data into a const array
separates the boiler plate data from the actual code.

use hardcoded array for hardcoded placement menu defaults

removed useless code

'tools' is transformed to lower case some lines above,
'm_tools_ is a copy of the lower cased 'tools'.

code deduplication by using <algorithm> and FbTk/STLUtil.hh

code deduplication by using <algorithm> and FbTk/STLUtil.hh

code cleanup, missing commit for 2b62cf973318978bc222db7719552148275887db

bugfix: 'reset' nr_shapes to '0' after last instance of 'Shape'

cleanup and code deduplication

* ClientPattern.cc: make compiler happy (complaints about XPROP not handled in switch)
* FbTk/FbPixmap.cc FbTk/StringUtil.cc: signed vs unsigned
* FbTk/FbString.cc: missing return
* WinClient.cc: create atoms only once; use helper function
* Window.cc: use a helper function

use one array instead of two to hold both 'names' and 'atoms' for the rootwindow

bugfix: create the corner pixmaps only once per screen

for each window (windows, menue etc) the initCorners() function of
FbTk/Shape.cc was called (which is ok). On each call the corner pixmaps
(of the Screen the window belongs to) were created and destroyed the
formerly created pixmaps. this is not needed.

bugfix: free the shape-corners on the last used 'Shape'

the global 's_corners' vector was still used on an application shutdown
(including ctrl-c SIGINT). depending on when 's_corners' was created on
the stack this could lead to an exception ('pure virtual called') while
trying to free the 'FbPixmaps' without having a valid
'FbTk::Application::instance()' left.

bugfix: small typo in last cleanup prevented loading workspace names

cosmetic code cleaning

* use FbTk::StringUtil::number2String() to avoid 'sprintf'
* use FbTk::Util::clamp()
* use FbTk::STLUtil::destroyAndClear()
* whitespaces

code simplification

we do not need a std::map just to store an attribute on an AtomHandler,
it makes housekeeping just more annoying.

code simplification

updated config version to '13' and adjusted 'fluxbox-update_configs' accordingly

our users should migrate seamlessly to our new windows-cycling behaviour
without losing their current way of doing things. so, 'fluxbox-update_configs'
tries its best to add '(workspace=[current])' wherever it looks like a valid
place for it. such changed lines are marked by '!! FBCV13' at the end and can
be easily spotted in case the updater got it wrong.

addtional changes:

* added '-check' to 'fluxbox-update_configs' to check the version number in
  '~/.fluxbox/init' vs. the version number of 'fluxbox-update_configs'

* moved the update-code for each version into its own function, easier
  housekeeping

added '(workspace=[current])' to our default keys

commit 882a50fe1d4930b156965c54d9b66ecb27b4c9b2 removed the hardcoded limit to
cycle to windows on other workspaces, though it was and IS a good default
behaviour. if users do not want this (they want to cycle to windows on other
workspaces), they should explicitly avoid '(workspace=[current])' in their
keysfile.

added 'SetXProp' action and (@PROP=foo) clientpattern

these two allow 'tagging' of arbitrary windows with 'tags' (or 'labels'). such 'tagged' windows can then be used in ':NextWindow (@PROP=foo)' commands to quickly cycle through a subset of available windows.
since the 'tags' are applied as real xproperties to a window they survive a restart of fluxbox or even another windowmanager. the user can also set the tags by using xprop(1).

the next step regarding the UI should be to visualize the tags of a window.

moved helper struct TextPropPtr into anonymous namespace

code cleanup

* moved code from public API to internals
* avoid code duplication ( while(!m_terms.empty()) ...)
* cosmetic '(*it)->' vs 'term.'

removed hardcoded limitation to cycle/focus windows on all workspaces

reasons:

* fixes #1732115, allows to have chatwindows on another workspaces and reach them via :NextWindow (urgent=yes)
* old behavior can be achieve by using the (workspace=[current]) pattern

disabled potentially dead code

simpler code

removed dead code

bugfix: initialize the Shape of a menu AFTER we created the window for the menu

on startup a lot of 'Fluxbox: X Error: BadDrawable (invalid Pixmap ...)' occured.
this was caused by using an empty 'Window' to create the shape.

minor cleanup

reduced 'switch/case' and 'else if' hell a little bit

added FbTk::Util::clamp() and simplified related code

use FbTk apis instead of raw xlib calls

simpler to use FbTk/Timer api

cosmetic

simpler way of expressing 'Singleton' for 'FbAtoms'

fixed code duplication

improved 'escapeRememberChars()' routine by traversing the string only once

removed obsolete 'getuint()' function

avoid code duplication

improved extract*Number functions from FbTk/StringUtil.cc

cosmetic fix: looks like a copyNpaste issue

code simplification

updated ChangeLog

avoid code duplication

removed unused code

introduced FbTk::BidiString

a 'BidiString' holds both the logical content and the visual reordered
version of the content of a string. this helps to reduce the number of
calls to reorder the string before drawing it (as introduced in the patch
from Ken Bloom) and to be more consistent in menus and textboxes (drawing
cursors and underlining text).

removed redundant if-statement

updated 'Changelog'

avoid constructing new strings implicit

cosmetic

reuse temporary memory for reencoding / reordering fribidi-strings

added info about 'BIDI' support to 'fluxbox -info'

added support for bidirectional text

minor code simplification

fixed the default 'OnTitlebar Mouse1' actions

code simplification / deduplication

* parse the string only once for a bunch of chars to check instead of
  starting over again and again from the beginning, created a helper
  function to do this (FbTk::StringUtil::findCharFromAlphabetAfterTrigger)

* put same code into a function (setClockModeLabel())

* use much simpler code to switch between 12h and 24h mode and replace
  the fmt-switches

moved knowledge about '_NET_SYSTEM_TRAY_S' into the 'SystemTray' class

fixed compiler warning 'comparison between signed and unsigned integer expressions'

reenable clickRaise(), but on any button press if no key-action was found

fixed spelling

bugfix: compiler warning

fixed compiler warnings regarding signed/unsigned and () around expressions

updated Changelog

implemented 'ActivateTab' action to (re)allow activation of tabs via mouse

fixed typo

added more needed bindings to the default 'keys' file to mimic old behavior

Restoring our own custom INSTALL file

While automake *can* generate a generic version of this file for us, we don't
want it!

Removing more autoconf-generated files

There is no need to keep INSTALL, install-sh, ltconfig, mkinstalldirs in git, as
they can be created by 'automake -a -c' as needed.

In fact, it turns out ltconfig and mkinstalldirs are not needed at all any more.

Merging from upstream tar bzip

Moving themes in the git branch from 2.5 to 3 to match tenr's site.

bugfix: another crash when cleaning up signals

While 769130f51a8f did fix one issue, it introduced another by changing the
logic related to the new SignalTracker.  The original logic (introduced in
9ad388c5bf16) was:
  -> in 'leave(Signal)', only call 'disconnect'
  -> in 'leaveAll()', call 'disconnect' and 'disconnectTracker'
But 769130f51a8f inverted this, calling 'disconnectTracker' in both cases but
only 'disconnect' in the 'leaveAll()' case, which would leave unattached signals
around after calling 'leave(Signal)'.

This fix not only repairs the logic, but renames the ambiguous 'disconnect'
boolean to something more explicit: 'withTracker'.

Updating ChangeLog for StrictMouseFocus change

Implement StrictMouseFocus

As noted in the previous commit, StrictMouseFocus now works as advertised:
  Focus follows mouse on every EnterNotify event (except when the "ClientMenu"
  closes or during alt+tab window cycling)

Add new focus model: StrictMouseFocus

This is not actually implemented yet, but from now on, "MouseFocus" means:
  Focus follows mouse only when you are moving the mouse, any EnterNotify events
  caused by non-mouse operations (window closing, keycommands, changing
  desktops) will *not* shift focus

And once fully-implemented, "StrictMouseFocus" will mean:
  Focus follows mouse on every EnterNotify event (except when the "ClientMenu"
  closes or during alt+tab window cycling)

bugfix: do not use invalid iterators while looping thru a container which gets destroyed

mostly cosmetic fixes, mainly discovered by 'clang --analyze'

reordering of Resource-related stuff was because of

   "error: explicit specialization of 'getString' after instantiation"

complaints.

fixed potential memory leak

cleanup created corner pixmaps, moved the initCorners() function out of the class

initialize all member variables, otherwise unclean state in some circumstances

(valgrind complained a lot about ::updateGeometry() accessing uninitialized variables)

prevent crash if m_keylist is 0

again, i do not know yet, why this could happen.

cleanup: missing initialization

i ran across problems on a freshly installed ubuntu without
any config files, m_keylist was not initialized, yet unsure why.

bugfix: crash when cleaning up signals

22fa5f544b35 was not fixing anything, the real cause is that the
SignalHolder still has a reference to a not existing Tracker.

compile fix: FD_ZERO (sys/select.h) on solaris wants to use memset(); closes #2997117

bugfix: when maximizing a shaded window, unshade it before

bugfix: added missing 'virtual' keyword, otherwise fluxbox crashes with 'pure virtual method called'

bugfix: resizing/moving a maximized window via keys do not end maximization state (#2980313)

added little helper function to disable the maximization state of a window while keeping its current position / size

bugfix: resizing stops _NET_WM_STATE_MAXIMIZED*, so trigger signal to set the properties correct

fixes partly #2980313, resize with keys still does not trigger _NET_WM props to be correct

upgrade CONFIG_VERSION to 11

cosmetic

use maximize options for fullscreen as well

deploy new key-bindings to old keys-files via fluxbox-update_configs

added OnLeftGrip, OnRightGrip, OnWindowBorder modifiers for keys file

this allows to move some hardcoded keysbindings into the keys file and
makes the code simpler

updated Changelog

cosmetic

use new closest head calculation code to place windows when clearing up heads

bugfix: moving (the center of) a maximized window out of a xinerama head could result in maximizing it over all heads

the old way of deciding which head to (re)maximize the current window
was to just test if the center of the window is INSIDE which head.

now we calculate the closest head which fixes the problem

updated changelog

bugfix: using 'int' on 64bit systems while setting window properties is wrong

using a smaller type ('long' on 64bit is 8 byte, 'int' is 4) results in
strange properties, eg:

  _NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_HORZ, undefined atom # 0x2726130

(when xpropping a maximized xterm). this might cause misbehavior in apps.

Updated changelog

Changed title signal in Focusable to new signal system

Added Tracker interface for SignalHolder.

This is used by SignalTracker so Signals can disconnect from it when
they die.

Minor fix for argument reference in MemFunSelectArgImpl

Initialize all variables in FbWindow

Added simple stress test in python

Added SelectArg.hh to Makefile.am

Added SelectArg and MemFunSelectArg*

The MemFunSelectArg* functions can be used to select
a specific argument from a signal. For example this would
select the string argument as argument to the callback:

Signal<void, int, float, string> signal;
signal.connect(MemFunSelectArg2(obj, &Object::takesOneStringArg));
signal.emit(10, 3.14, "hello");

...

void Object::takesOneStringArg(const string& value) {
...
}

Added missing RelaySignal.hh to Makefile.am

Changed Focusable::focusSig() to new signal system.

The focus signal emits the window that had the focus status changed.

Added FbTk::relaySignal, which relays new signals to old Subject type signals.

Fixed so testDemandAttention compiles

minor cleaning in MemFun.hh

Added MemFunIgnoreArgs which ignores aditional arguments.

For example connecting a function that takes two arguments
to a signal that emits three arguments:
struct Functor {
    void show(int a, int b);
};
Functor f;
Signal<void, int, int, int> s3;
s3.connect(MemFunIgnoreArgs(f, &Functor::show));

updated changelog

Changed #ifdef DEBUG ... cerr << to using fbdbg.

This will reduce the number of #ifdef DEBUG for
simple debug messages.
include "Debug.hh" and use fbdbg instead of cerr for debug.

bugfix: do not create the temporary menufile 'somewhere' in the filesystem but next to the final one

fixed little preprocessor error

updated ChangeLog entries

improved documentation of the code

optimization of how often fluxbox checks for the system time to display it in the clocktool

the idea (as a first patch) for this change was provided by
Thomas Habets (thomas at habets pp se). instead of having a
fixed interval each second, we now calculate the next point in
time based upon the format string used by the clocktool to render
the time. as long as no seconds are shown fluxbox now wakes up
once every minute.

updated changelog

recreated the generated manpages

fixed spelling

implemented 'MoveN' and 'ClickN' support in keys file.

the hardcoded 'OnTitlebar Mouse1 :Raise' (see Window.cc, FluxboxWindow::buttonPressEvent())
is disabled for now, should be added to fluxbox-update_configs

updated fluxbox-keys documentation, added 'Fullscreen'

cosmetic

Keep 'maximum/fullscreen' when moving a window between different heads

reportedly fix compiling on gcc 4.4 on Solaris

definition should match declaration

compile fixes for sun compiler 5.10: class Layer conflicts with class FbTk/Layer .. so just a little renaming

compile fixes for sun compiler 5.10: 'i want an extern C function ptr'

compile fixes for sun compiler 5.10: complains about 'not beeing able to initialize this from that'

minor typo

updated changelog

cosmetic: use FbTk::StringUtil::number2String()

build system: checking to link against extensions (Xinerama, Randr, Shape) is not enough, we have to check the headers as well

build system: moved some things around, 'finished configuring' message now at the end

build system: autocreate the 'missing' file, fixes the 'unknown --run option for missing' issue

updated changelog

just use the FbTk API

bugfix: stop wiping out ~/.fluxbox/keys

another little helper for FbTk::StringUtil: extractNumber()

updated changelog

removed unused code

compile fix: missing include guards

simpler code

compile fix: taken 'FbTk' out of includepath, Layer.hh and FbTk/Layer.hh confused the sun compiler

compile fix: missing headers (sun compiler complained about)

compile fix: using correct forward declaration for template classes

we got this 'Warning (Anachronism): Old syntax for explicit specialization or
 instantiation ignored.' with the solaris compiler

made code simpler

cosmetic fix: removed warning about double ';' after command

static xyz inside a anonymous namespace is not really needed, so i removed the namespace
to get rid of the compiler warning. it's more convinient for the developer
to put ';' after that REGISTER_COMMAND_PARSER

compile fix: ISO C++ forbids variable length array 'names'

compile fix: use the correct format string to parse the number

cosmetic: slightly less code to do the same

compile fix: sun compiler complains about missing std::mem_fun_t<>

cosmetic fixes: removed redundant ';' + some whitespaces

bugfix: 'HideMenus' command did not work if the user 'opened' an empty submenu.
'openeing' such an empty submenu lead to an already hidden menu referenced by
the 'shown' pointer

mwm hints can't control the close button

implemented visibility of titlebar buttons via the apps file

check for errno while parsing the deco mask

add some generated files to .gitignore

allow navigating multi-column menus with left and right arrows

more fixes for fluxconf mangling the keys file

make autohide only show the border or 1 pixel if borderless

allow matching screen number in ClientPattern

add a few items to fbgm

hide the menu when you click on a window

change default toolbar tools to:
prevworkspace, workspacename, nextworkspace, iconbar, systemtray, clock

make Raise/LowerLayer accept integer argument for number of layers, default 2

fix changing iconbar alignment and button width from init file

allow 'Ctrl' and 'Alt' as modifiers in keys file

allow "lower" as a reference point for MoveTo, etc.

previous fix for reverting iconbar to relative broke external tabs

change default toolbar head from 0 to 1

add window menu and alt-tab to error case for keys file

revert to relative iconbar alignment when too many windows are open

use current workspace in ClientPattern when client has no FbWindow

Cleaned up 'fbsetbg -h' output

Reordered the "Options" section and made it more clear that for setting solid,
gradient, or pattern textures, one should also refer to fbsetroot(1).

Updated ChangeLog

Added warning for "ChangeWorkspace" event

Merge branch 'mousefocus'

Removing improperly-added man pages.

These were leftovers from a marginally-botched rebase of my docs branch before
pushing to the main tree.

Don't complain on '-z' if there's no lastwallpaper

This hides the odd cornercase of users with no lastwallpaper file and no
background set in their style or overlay.

Adapted from the patch at
http://sourceforge.net/tracker/?func=detail&aid=2389567&group_id=35398&atid=413962

Allow 'background: unset'

When a user sets 'background: none' it really means "Do not let themes touch the
background I have already set with fbsetbg" -> It does still actually call
fbsetbeg to re-assert the proper background.

This new value 'unset' is for users who will use an alternate method to set
their background (root-tail, xscreensaver, or whatever).  It instructs fluxbox
to *never* run fbsetbg.

Error on incomplete MacroCmd key command

Exit loop for unterminated { } pair

Added note about cancelling key chains

Updated formatting for RESOURCES and ENVIRONMENT

Added note on ChangeWorkspace

Small edits for consistency

Added new 'make dist' target for ease in updating the manuals

Converted startfluxbox(1) to asciidoc format

Converted fbsetroot(1) to asciidoc format

Moved fbsetbg(1) to asciidoc format

Moved fbrun(1) to asciidoc format

Created fluxbox-menu(5)

This separates the menu-syntax portions of fluxbox.txt out into its own man
page, and includes a rather large rewrite of much of fluxbox.txt, as well as
small improvements in other pages.

Process all asciidoc-generated man pages with sed

This makes things a bit simpler and more generic.

Renamed fluxstyle(1) to fluxbox-style(5)

Added missing asciidoc manual attributes

Added :man source:, :man revision:, and :man manual: attributes to all remaining
asciidoc manpages, and regenerated them with asciidoc-8.2.7

Removed APPLICATIONS section from fluxbox(1)

This is now in its own man page, fluxbox-apps(5).

Added fluxbox-apps(5) manpage

This now shares the CLIENT PATTERNS section in common with fluxbox-keys(5), so I
split this out into a client-patterns.txt which is included by both
fluxbox-apps.txt and fluxbox-keys.txt.

don't try to install fbrun.1 twice.

minor cosmetics

minor cosmetics

src/TextDialog.cc: removed useless stdexcept header inclusion.

No functional change.

Signed-off-by: Slava Semushin <php-coder@altlinux.ru>

src/Keys.cc(deleteTree): use FbTk::STLUtil::destroyAndClearSecond() instead of self-written code.

No functional change.

Signed-off-by: Slava Semushin <php-coder@altlinux.ru>

doc/ru/fluxbox.1.in: fixed typo (s/Remeber/Remember/).

Signed-off-by: Slava Semushin <php-coder@altlinux.ru>

Renamed function svnversion() to gitrevision() because now we uses GIT.

No functional change.

Signed-off-by: Slava Semushin <php-coder@altlinux.ru>

.gitignore: added more files.

Also sort file.

Signed-off-by: Slava Semushin <php-coder@altlinux.ru>

Renamed .cvsignore to .gitignore

Signed-off-by: Slava Semushin <php-coder@altlinux.ru>

compilefix

buildfix: fluxbox didnt link when configured with --disable-remember

removed autogenerated file

dont try to read file when they are actually a directory

remove unnecessary xpm.h include in imlib code

fixed resize bug (caused by typo, see #2498507)

don't reload keys file on modifier map events, just re-grab keys

increase default size of toolbar and icon buttons

unrevert 1fdef35e51
										x
Mathias should listen to me when I say "by the way, I know you liked the code I
just removed; you should change your keys file to use
:MacroCmd {Focus} {Raise} {StartMoving}". Behavior in 1.0.0 and previous was
that alt+click would focus and raise, regardless of whether the window was moved
or not. If mathias really wants his alt+drag to preserve stacking order, he
should add Mouse<N>Move events to the keys file to distinguish moving from
clicking. I've been planning on doing it anyway.

additional fix for the resize bug

reverted 1fdef35e51, added more info about that feature

don't allow resizing to negative dimensions

this fixes a problem when the user resizes a window over the opposite border.
as a result a signed overflow occured which lead to quite huge windows.

ignore XRandr events that don't actually change the screen size

remove doc/asciidoc/fluxbox.1 from index

merge menuDelay and menuDelayClose options

focus window when done dragging to a new workspace with outline moving

using namespace instead of a useless class

don't show window on new workspace when warping with outline moving

show/hide tooltip if title length changes enough while mouse is over the iconbutton

fix windows mapping into IconicState again

remove some unneeded code

allow relative path for background images in style files

remove menu modes

remove follow models

remove line style resources from init file

remove rootcommand from init file

add a message to default init file explaining why there aren't any options there

recognize --option in addition to -option for most things

add -print option to fbrun to return result to stdout instead of executing it

in ClickFocus, replay pointer before focusing window

fix CustomMenu and ClientMenu commands from fluxbox-remote

break keychains after an invalid key is pressed (which unfortunately will be swallowed)

fix flickering of shaped windows on focus changes

fix restacking

don't flash original window in the middle of cycling focus

reset background on resolution change

restore missing config files on reconfigure

Changed resize signal in BScreen to use the new signal system

Changed workspace area signal to use the new signal system

Merge branch 'master' of fluxbox@git.fluxbox.org:fluxbox

Conflicts:

	ChangeLog

Change focused signal to use the new signal system

Changed icon list signal in BScreen to use the new signal system

Changed client list signal in BScreen to use the new signal system

Changed background changed signal in BScreen to use the new signal system

Changed workspace names signal in BScreen to use the new signal system

Changed current workspace signal in BScreen to use the new signal system

no virtuals needed Signals, added leaveAll for SignalTracker which must be used before all screens dies.

re-fix maximizing problem with non-northwest gravity windows

fix placement of windows with non-default decorations

fix a few things with new signal code

Merge branch 'master' of fluxbox@git.fluxbox.org:fluxbox

Conflicts:

	ChangeLog

Changed workspace count signal in BScreen to use the new signal system.

Added new Signal/Slot system in FbTk

This is suppose to replace the obsolete Subject/Observer classes.
See the src/tests/testSignals.cc for basic usage.

minor changes for news

new version

added RectangleUtil.hh to build

Fixed a pixmap resource leak with selected pixmap in menus.

menu.hilite.selected.pixmap and menu.selected.pixmap was not
deleted while switching between non-pixmap styles and pixmap styles.

some minor code cleaning.

fix some default values

try to fix some weird focus issues

fix program crashes caused by unshading

be aware of badly specified _NET_WM_ICONS

fix updating of keys file for scrolling on toolbar

update workspace names atoms/resources when adding a new workspace
also removed unnecessary items from default init file

remove unnecessary signals causing toolbar renders on workspace change

turn on opaque window moving by default

add check to configure script to detect old versions of Xrandr

fix maximize/fullscreen for windows with non-Northwest gravity

remove tooltip when IconButton is destroyed

add windowmenu to dist package

back to git version

resize fullscreen windows when resolution changes

some documentation updates

update window's size hints when client updates size hints

included some missing files in distribution

removed ObjectResource.hh and CompareWindow.hh

new version 1.1

fixes for NEWS entry

updated for 1.1

highlight the nearest menu item when the current one is disabled, and add separators to focus model menu

fix focus after tabbing

missed one

use FbMenu::window instead of WindowCmd<>::window for displaying items in the window menu

more fun with global variables

don't change a fullscreen window's layer when its transient takes the focus

move some things from FluxboxWindow to WindowState

make FbWinFrame and FluxboxWindow share a WindowState object

remove option to disable decorations on transient windows

move decoration handling for non-resizable windows to SizeHint class

move FbWinFrame::State class to a new file

use old focus/raise behavior for default alt+left/right mouse bindings

toolbar placement menu wasn't updating

make clicking on the border of the toolbar activate toolbar buttons

fix for restoring horizontally or vertically resized windows

fix reading iconbar border from theme

resize maximized windows when the toolbar or slit changes size

when a transient dies, revert focus to its parent

make ShowDesktop and Deiconify commands maintain focus order

allow various combinations of shaded, maximized, and fullscreen states

be a little smarter about size hints in tabbed windows

don't let MWM hints override defaultDeco

another parsing fix

remove borders from maximized windows

add -sync command line option for debugging X issues

accidentally left this on

move fullscreen and maximization handling to FbWinFrame

don't apply rounded corners to windows without decorations

apply patch to fix memory leak that shouldn't exist

fix cycling with minimized windows

fix parsing of Delay command

make Swing apps only somewhat horribly broken again

;

some cleanup

add SendToNextHead/SendToPrevHead commands, plus some cleanup in CurrentWindowCmd

split documenation into different directories

create section 5 manpages as well

fixed some menu documentation

fix match limits in apps file, plus some documentation

ShowDesktop should ignore everything on the desktop layer, not just windows of type Desktop

add SetDecor key command

make creating manpages easier

shift+enter wasn't sending right click if the menu item had a submenu

add [transient] tag to apps file to match transient windows

update keys file for changes to NextWindow syntax

fix :Focus <pattern> when all windows are minimized

fix a bug with Some and Every commands and the stupid global current window variable

update the manuals for previous commit

combined code for saved window positions and MoveTo key command
added left, right, top, and bottom center reference points

fix some defaults

add top, left, right, and bottom center tab placement options

add SetTitle and SetTitleDialog key commands

revert focus when closing dialogs

some cleanup

cosmetic changes

move interpretation of normal hints to size hint class

cosmetic api change

fix compilation

let FbWinFrame handle decorations in fullscreen state

move getDecoMaskFromString to FbWinFrame

fix some consts and private functions

group some window properties into a new class FbWinFrame::State

have fullscreen and maximization code call applySizeHints directly

move some frame size calculations to FbWinFrame

aspect ratios should take base size into account, fix size hint initialization

move size hint code to methods in size hint struct, restructure them a little

move size hint code to FbWinFrame

move size hints to a struct

cleanup of some files

Merge branch 'master' into to_push

Merge branch 'makefile_correct' into to_push

feed the right git revision used to build fluxbox into defaults.hh

use _NET_WM_ICON property as resource for icons, fixed partly #1852693

instead of depending on proper icons in the old icccm wmhints, fluxbox now
tries to get the icon data stored in _NET_WM_ICON

more fun with the window menu

removed goto

fix highlighted menu item on mouse out

Fix a freed memory access in ~BScreen.

mit->second->parent() == 0 didn't do what it was supposed to. m_parent being
zero does not imply that no pointer points to it.

Signed-off-by: Tomas Janousek <tomi@nomi.cz>

Consistency: alpha submenu of WindowMenu should not have title.

Signed-off-by: Tomas Janousek <tomi@nomi.cz>

Fix a freed memory access in Keys::doAction.

The thing next_key pointed to was getting freed in deleteTree.

Signed-off-by: Tomas Janousek <tomi@nomi.cz>

Fix crash with apps reloading.

Yeah, we shouldn't delete pointers that are mentioned elsewhere...

Signed-off-by: Tomas Janousek <tomi@nomi.cz>

fix window menu again

check pointer, even though it shouldn't be necessary

fix rotation

fix focus revert when closing menu

fix warning

Merge branch 'xinerama_randr'

minor correction of include names

reordering

cosmetics

std::string.c_str() is never NULL

don't require final {} on :If

fix issue with multiple spaces in filename in fbsetbg

use hash instead of which in fbsetbg

fix some potential bugs with window menus

fix potential infinite loop in transient windows

fix some issues with window menus

fix some updates on style change

move position and geometry windows into their own class

Fix missing destructor warning

Merge branch 'master' of fluxbox@gitfbox:fluxbox

use function pointer for CommandParser::Command

fix crashes on restart

fix initialization of WorkspaceNameTheme

fix some issues with reverting focus

move some stuff from Fluxbox to BScreen

forgot to add this

make FbTk::Command a template class, split parsing information out of ObjectRegistry

split WinButtonTheme into multiple themes

switch FbWinFrameTheme to use FocusableTheme

added new ThemeProxy for automatically handling focused vs. unfocused ThemeItems

update code to use ThemeProxy

add a level of indirection to themes

remove some unnecessary code

remove old svn $Id$ tags

merged

moved seldom used code to where it is actually used, no need to include code into compilation when its not needed

more encapsulation for Ewmh

more header 'correctness'

decoupling, moved private datastructures to Keys.cc

fix some flickering on focus change

fix compatibility with older gcc versions

Fix minimize regression caused by b5c354b9.

this really needs to be fixed

Fix freeze with actions on external tab.

removed some unneeded headers

remove some (hopefully) unneeded header includes

forgotten inlines from previous round

'inline' in class declaration is implicitly inline

move #define SHAPE to config.h instead of -DSHAPE on command line

moved DelayedCmd from Screen.cc to FbTk/Timer.cc, added it to the keys file

move shape handling from FbMenu to FbTk::Menu

merge MenuTheme with FbTk::MenuTheme

move Shape to FbTk

move STLUtil to FbTk

move RegExp to FbTk

move Parser to FbTk

moved Container to FbTk

moved BorderTheme and TextTheme to FbTk

architecture astronomy

simplify the window transparency menu and handling a bit

stupid &

revert previous patch until it can be fixed

changing focusnew/mousefocus should affect windows that are already open

updated german translations for maximization menu

implement some focus policies for splash, dock, and desktop windows

don't add new windows to front of focus list if they don't acquire the focus

removed KDE configure option

added resource session.screen<N>.slit.acceptKdeDockapps

fix showing program icons with depth=1 in menus

make bit depth accessible from an FbDrawable

`hash -t' seems to be bash-only

replaced `which' with the bourne shell built-in `hash' and fixed some --program-prefix/suffix problems

search subdirectories when looking for icons

minor fixes for handling ConfigureRequest events

added focused/unfocused borders to styles

make FbWinFrame aware of the decoration state

if a window is prevented from stealing the focus, don't put it on top

don't allow clients to move or resize fullscreen/maximized windows

make better decisions about when to allow stealing the focus

leave fullscreen windows on top, even without the focus, as long as focused window is on another head

remove 'friend' declaration in Window.hh

little cleanup

added key command StartTabbing

add some more useful keybindings to the default keys file

remove `OnTitlebar Mouse2 :Lower', as it interferes with tabbing

fixed backwards compatibility for toolbar/tab styles

fix menuitem height on startup

convert macro command parsing to use new StringUtil function

added ForEach key command

replace svn stuff with git

"fix" `About' item in fbgm with tcsh, #1806327

fix a few $HOME-related issues in fbgm

fixed "iconify" menu item

check apps file settings after ewmh and gnome

always focus a client that gets raised in the focused window

don't minimize a window just because its transient got minimized

remove reassoc argument from FluxboxWindow::deiconify

remove some unnecessary uses of FluxboxWindow::deiconify

don't let transient windows steal the focus from other programs

clicks on the handle were matching OnTitlebar

switched Mouse Tab Focus and Click Tab Focus nls entries

open transient windows on same workspace as parent